[U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver

Wolfgang Denk
2011-12-20T23:09:23Z

Dear Rob Herring,

In message <4EF11209.5050102@gmail.com> you wrote:
>
> > Are there going to be any users for this driver?
>
> Yes. Patch 2/2 adds support to Calxeda Highbank.

I saw this myself 5 seconds later, but my "send" button has no "undo"
function ;-) Sorry...

> > Checkpatch says:
> >
> > WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
> > #461: FILE: drivers/net/calxedaxgmac.c:317:
> > +} __attribute__((aligned(32)));
> >
> > Is there any special reason not to change this?
>
> I thought it was a false positive because I didn't find any other users
> of __aligned().

I think we should change this. [I can do this when applying, if you
like.]

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What the gods would destroy they first submit to an IEEE standards
committee.