[U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver

Rob Herring
2011-12-20T22:54:01Z

Wolfgang,

On 12/20/2011 04:42 PM, Wolfgang Denk wrote:
> Dear Rob Herring,
>
> In message <1323983750-3399-1-git-send-email-robherring2@gmail.com> you wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> This adds ethernet driver for Calxeda xgmac found on Highbank SOC.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> ---
>> v3:
>> - whitespace fixes
>> - move reset to .init function
>> - fix calxedaxgmac_initialize return values
>> - fix 2 build warnings
>>
>> v2:
>> -Convert register base plus offset to struct
>> -drop ethaddr env setting
>> -drop valid mac address check
>>
>> README | 3 +
>> drivers/net/Makefile | 1 +
>> drivers/net/calxedaxgmac.c | 553 ++++++++++++++++++++++++++++++++++++++++++++
>> include/netdev.h | 1 +
>> 4 files changed, 558 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/net/calxedaxgmac.c
>
> Are there going to be any users for this driver?

Yes. Patch 2/2 adds support to Calxeda Highbank.

>
> Checkpatch says:
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
> #461: FILE: drivers/net/calxedaxgmac.c:317:
> +} __attribute__((aligned(32)));
>
> Is there any special reason not to change this?

I thought it was a false positive because I didn't find any other users
of __aligned().

Rob