From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier
Date: Thu, 15 Dec 2011 09:56:53 +0100 [thread overview]
Message-ID: <1323939415-21743-2-git-send-email-andreas.devel@googlemail.com> (raw)
In-Reply-To: <1323939415-21743-1-git-send-email-andreas.devel@googlemail.com>
From: Andreas Bie?mann <biessmann@corscience.de>
size_t is not always 'unsigned int', use corret length modifer.
This patch fixes following warning:
---8<---
cmd_sf.c: In function 'spi_flash_update_block':
cmd_sf.c:130: warning: format '%#x' expects type 'unsigend int', but argument 4 has type 'size_t'
cmd_sf.c:135: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'size_t'
--->8---
Signed-off-by: Andreas Bie?mann <biessmann@corscience.de>
cc: Mike Frysinger <vapier@gentoo.org>
cc: Thomas Chou <thomas@wytron.com.tw>
---
changes since v1: split off into single patches
total: 0 errors, 0 warnings, 14 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
0001-cmd_sf.c-fix-printf-length-modifier.patch has no obvious style problems and is ready for submission.
common/cmd_sf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cmd_sf.c b/common/cmd_sf.c
index 7225656..612fd18 100644
--- a/common/cmd_sf.c
+++ b/common/cmd_sf.c
@@ -127,12 +127,12 @@ static int do_spi_flash_probe(int argc, char * const argv[])
static const char *spi_flash_update_block(struct spi_flash *flash, u32 offset,
size_t len, const char *buf, char *cmp_buf, size_t *skipped)
{
- debug("offset=%#x, sector_size=%#x, len=%#x\n",
+ debug("offset=%#x, sector_size=%#x, len=%#zx\n",
offset, flash->sector_size, len);
if (spi_flash_read(flash, offset, len, cmp_buf))
return "read";
if (memcmp(cmp_buf, buf, len) == 0) {
- debug("Skip region %x size %x: no change\n",
+ debug("Skip region %x size %zx: no change\n",
offset, len);
*skipped += len;
return NULL;
--
1.7.7.3
next prev parent reply other threads:[~2011-12-15 8:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 6:36 [U-Boot] cmd_sf warning on size_t Thomas Chou
2011-12-14 9:34 ` Andreas Bießmann
2011-12-14 10:04 ` [U-Boot] [PATCH/RFC] fix several printf() modifiers Andreas Bießmann
2011-12-15 2:22 ` Thomas Chou
2011-12-15 2:39 ` Graeme Russ
2011-12-15 5:36 ` Mike Frysinger
2011-12-15 5:35 ` Mike Frysinger
2011-12-15 8:30 ` Andreas Bießmann
2011-12-15 19:22 ` Mike Frysinger
2011-12-15 8:56 ` [U-Boot] [PATCH v2 0/3] fix several printf() length modifers Andreas Bießmann
2011-12-15 8:56 ` Andreas Bießmann [this message]
2011-12-15 12:20 ` [U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier Mike Frysinger
2011-12-17 22:56 ` Wolfgang Denk
2011-12-15 8:56 ` [U-Boot] [PATCH v2 2/3] fat.c: " Andreas Bießmann
2011-12-15 12:21 ` Mike Frysinger
2011-12-17 22:56 ` Wolfgang Denk
2011-12-15 8:56 ` [U-Boot] [PATCH v2 3/3] avr32:mmu.c: " Andreas Bießmann
2011-12-15 12:21 ` Mike Frysinger
2011-12-17 22:57 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323939415-21743-2-git-send-email-andreas.devel@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox