From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8763BC77B7A for ; Sat, 13 May 2023 20:32:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E92C785659; Sat, 13 May 2023 22:32:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Xox0RmOF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C1F985EDD; Sat, 13 May 2023 22:32:47 +0200 (CEST) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 36DD885659 for ; Sat, 13 May 2023 22:32:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francis.laniel@amarulasolutions.com Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3078aa0b152so5761541f8f.3 for ; Sat, 13 May 2023 13:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1684009964; x=1686601964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sq5TuWVM30lRAkH6tQaPSOtjcN+m9JfMamp2a783kLQ=; b=Xox0RmOFmRRUNSLetHuzhFeWhQvn27MLiUN4HryXDkG8fvB8P98q9Vn+UFHJTbXLoQ TDO3oC6UbfAWK1tQ/XP0yuRge1dHKG8mTvQovWn0jmC5CGxLiS7B2SmmsPp/7KYa6A3j u9scOWuUpBF35Idf3LQulHY+QMnZgPgKjF/6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684009964; x=1686601964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sq5TuWVM30lRAkH6tQaPSOtjcN+m9JfMamp2a783kLQ=; b=keqsVC1ZjDncwlc2pnG+XC6KD0ZRNGs6shXqLR+udxLx/ygA3l9p5rdQHPuDs8PWqo RvypfUl5hjT71baWrouQ08kW/71WUtAlaYnoDIYXbgObLRKTcf2O92THxuhT9g8yUgP7 4fRHLgFyzZt6m5nI7f3z0qtJ4h8YSpWAGV2Shy/TCrHV9vZJm5B9lCOPy3GEec1M2W4S kMSrkkkxMPA87i7C6ji4avUGugiUE3Pld5uHFoJdTUrJ0ACT8uqB34MRd9D746bbZd2p 22vtAFAdBWFuJ8yNoBuVPd7domz9XACce0VgiWYvpk+7ezYuOPOP0KdXkPCdbzkiehEX sAFA== X-Gm-Message-State: AC+VfDw4eFmvoWn+tf5UU/nSsmTVaXKPEqJ+0WRnqRM0G9EpXGpGWYhK TigTLo0tmWOsC/APgdVcoLPuZw== X-Google-Smtp-Source: ACHHUZ45aKMxoOw3QXdqhNpV3ZG8cBot+UIijj9h7Z0uM0J4eVm+4nqh5SjvvAMyBcZygrWfb8QToQ== X-Received: by 2002:adf:f344:0:b0:308:d687:c1f9 with SMTP id e4-20020adff344000000b00308d687c1f9mr4312316wrp.63.1684009964618; Sat, 13 May 2023 13:32:44 -0700 (PDT) Received: from pwmachine.localnet ([213.94.16.214]) by smtp.gmail.com with ESMTPSA id z9-20020a05600c114900b003f4069417absm29695496wmz.24.2023.05.13.13.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 13:32:44 -0700 (PDT) From: Francis Laniel To: Heinrich Schuchardt Cc: Michael Nazzareno Trimarchi , Tom Rini , Simon Glass , Harald Seiler , Ilias Apalodimas , Ramon Fried , Pali =?ISO-8859-1?Q?Roh=E1r?= , Sean Edmond , Tobias Waldekranz , Masahisa Kojima , John Keeping , Devarsh Thakkar , Nikhil M Jain , Fabrice Gasnier , Stefan Roese , u-boot@lists.denx.de Subject: Re: [RFC PATCH v8 09/23] cli: Add menu for hush parser Date: Sat, 13 May 2023 21:32:42 +0100 Message-ID: <13264060.uLZWGnKmhe@pwmachine> In-Reply-To: References: <20230512200331.51457-1-francis.laniel@amarulasolutions.com> <20230512200331.51457-10-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Le samedi 13 mai 2023, 02:03:11 WEST Heinrich Schuchardt a =E9crit : > On 5/12/23 22:03, Francis Laniel wrote: > > For the moment, the menu contains only entry: HUSH_OLD_PARSER which is = the > > default. > > The goal is to prepare the field to add a new hush parser which guarant= ees > > actual behavior is still correct. > >=20 > > Reviewed-by: Simon Glass > > Signed-off-by: Francis Laniel > > --- > >=20 > > cmd/Kconfig | 13 +++++++++++++ > > common/Makefile | 2 +- > > 2 files changed, 14 insertions(+), 1 deletion(-) > >=20 > > diff --git a/cmd/Kconfig b/cmd/Kconfig > > index 87291e2d84..2c50c9f7b5 100644 > > --- a/cmd/Kconfig > > +++ b/cmd/Kconfig > > @@ -23,6 +23,19 @@ config HUSH_PARSER > >=20 > > If disabled, you get the old, much simpler behaviour with a=20 somewhat > > smaller memory footprint. > >=20 > > +menu "Hush flavor to use" > > + depends on HUSH_PARSER > > + > > + config HUSH_OLD_PARSER >=20 > If there will be alternative parsers in future, you should use > choice/endchoice even if there is only one option today. In a previous version of this contribution, I used choice. But we then decided to use different Kconfig to permit having several parse= r=20 living at the same time. =46or the reasoning behind this, please take a look at my other mail. > Best regards >=20 > Heinrich >=20 > > + bool "Use hush old parser" > > + default y > > + help > > + This option enables the old flavor of hush based on hush=20 Busybox from > > + 2005. > > + > > + It is actually the default U-Boot shell when decided to use=20 hush as > > shell. +endmenu > > + > >=20 > > config CMDLINE_EDITING > > =20 > > bool "Enable command line editing" > > depends on CMDLINE > >=20 > > diff --git a/common/Makefile b/common/Makefile > > index c87bb2e78b..93d0a5a309 100644 > > --- a/common/Makefile > > +++ b/common/Makefile > > @@ -8,7 +8,7 @@ ifndef CONFIG_SPL_BUILD > >=20 > > obj-y +=3D init/ > > obj-y +=3D main.o > > obj-y +=3D exports.o > >=20 > > -obj-$(CONFIG_HUSH_PARSER) +=3D cli_hush.o > > +obj-$(CONFIG_HUSH_OLD_PARSER) +=3D cli_hush.o > >=20 > > obj-$(CONFIG_AUTOBOOT) +=3D autoboot.o > > =20 > > # # boards