From: Stephan Linz <linz@li-pro.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] microblaze: Enable several ethernet driver compilation
Date: Tue, 31 Jan 2012 20:05:05 +0100 [thread overview]
Message-ID: <1328036705.2688.28.camel@keto> (raw)
In-Reply-To: <4F27AD9E.4050308@monstr.eu>
Am Dienstag, den 31.01.2012, 10:00 +0100 schrieb Michal Simek:
> Stephan Linz wrote:
> > U-Boot's multipple network supports enables to use
> > several ethernet drivers but microblaze-generic
> > platform config file select only one driver.
> >
> > Reported-by: Michal Simek <monstr@monstr.eu>
> > Signed-off-by: Stephan Linz <linz@li-pro.net>
> > ---
> > include/configs/microblaze-generic.h | 12 ++++++++----
> > 1 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h
> > index 03a6f5a..09ac870 100644
> > --- a/include/configs/microblaze-generic.h
> > +++ b/include/configs/microblaze-generic.h
> > @@ -65,11 +65,15 @@
> >
> > /* ethernet */
> > #undef CONFIG_SYS_ENET
> > -#ifdef XILINX_EMACLITE_BASEADDR
> > -# define CONFIG_XILINX_EMACLITE 1
> > +#if defined(XILINX_EMACLITE_BASEADDR)
> > +# define CONFIG_XILINX_EMACLITE 1
> > # define CONFIG_SYS_ENET
> > -#elif XILINX_LLTEMAC_BASEADDR
> > -# define CONFIG_XILINX_LL_TEMAC 1
> > +#endif
> > +#if defined(XILINX_LLTEMAC_BASEADDR) || defined(XILINX_LLTEMAC_BASEADDR1) || \
> > + defined(XILINX_LLTEMAC_BASEADDR2) || defined(XILINX_LLTEMAC_BASEADDR3) || \
> > + defined(XILINX_LLTEMAC_BASEADDR4) || defined(XILINX_LLTEMAC_BASEADDR5) || \
> > + defined(XILINX_LLTEMAC_BASEADDR6) || defined(XILINX_LLTEMAC_BASEADDR7)
> > +# define CONFIG_XILINX_LL_TEMAC 1
>
> Why to do it in this way? I believe that the first lltemac driver will have XILINX_LLTEMAC_BASEADDR
> and then others.
Right, but we need a definitive agreement that it is so (Xilinx BSP
generator). Did we them? If yes I will drop this part and insert your
original condition (test only XILINX_LLTEMAC_BASEADDR).
> But for all configurations if there is lltemac driver then will have anyone just BASEADDR.
yep
br,
Stephan
next prev parent reply other threads:[~2012-01-31 19:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 15:51 [U-Boot] [PREVIEW] LL TEMAC v10 refactored -- for evaluation only Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 1/8] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2012-02-23 11:57 ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 2/8] microblaze: Enable several ethernet driver compilation Stephan Linz
2012-01-31 9:00 ` Michal Simek
2012-01-31 19:05 ` Stephan Linz [this message]
2012-02-23 11:49 ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 3/8] microblaze: Enable phylib and mii support Stephan Linz
2012-02-23 11:52 ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 4/8] microblaze: Enable TFTP put command Stephan Linz
2012-02-23 11:51 ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 5/8] microblaze: Xilinx BSP to U-Boot conversion matrix Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 6/8] microblaze: Add faked LL_TEMAC driver configuration Stephan Linz
2012-01-31 9:01 ` Michal Simek
2012-01-31 19:27 ` Stephan Linz
2012-02-23 11:53 ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 7/8] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 8/8] microblaze: ll_temac: export xilinx_ll_temac_eth_init() for evaluation Stephan Linz
2012-02-23 11:56 ` Michal Simek
2012-02-23 19:02 ` Stephan Linz
2012-02-23 12:22 ` [U-Boot] [PREVIEW] LL TEMAC v10 refactored -- for evaluation only Michal Simek
2012-02-23 19:39 ` Stephan Linz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328036705.2688.28.camel@keto \
--to=linz@li-pro.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox