From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Linz Date: Tue, 31 Jan 2012 20:05:05 +0100 Subject: [U-Boot] [PATCH 2/8] microblaze: Enable several ethernet driver compilation In-Reply-To: <4F27AD9E.4050308@monstr.eu> References: <1327852301.3638.177.camel@keto> <00eaabafa2b64a5d5857067588261f35e5581274.1327848193.git.linz@li-pro.net> <4F27AD9E.4050308@monstr.eu> Message-ID: <1328036705.2688.28.camel@keto> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am Dienstag, den 31.01.2012, 10:00 +0100 schrieb Michal Simek: > Stephan Linz wrote: > > U-Boot's multipple network supports enables to use > > several ethernet drivers but microblaze-generic > > platform config file select only one driver. > > > > Reported-by: Michal Simek > > Signed-off-by: Stephan Linz > > --- > > include/configs/microblaze-generic.h | 12 ++++++++---- > > 1 files changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h > > index 03a6f5a..09ac870 100644 > > --- a/include/configs/microblaze-generic.h > > +++ b/include/configs/microblaze-generic.h > > @@ -65,11 +65,15 @@ > > > > /* ethernet */ > > #undef CONFIG_SYS_ENET > > -#ifdef XILINX_EMACLITE_BASEADDR > > -# define CONFIG_XILINX_EMACLITE 1 > > +#if defined(XILINX_EMACLITE_BASEADDR) > > +# define CONFIG_XILINX_EMACLITE 1 > > # define CONFIG_SYS_ENET > > -#elif XILINX_LLTEMAC_BASEADDR > > -# define CONFIG_XILINX_LL_TEMAC 1 > > +#endif > > +#if defined(XILINX_LLTEMAC_BASEADDR) || defined(XILINX_LLTEMAC_BASEADDR1) || \ > > + defined(XILINX_LLTEMAC_BASEADDR2) || defined(XILINX_LLTEMAC_BASEADDR3) || \ > > + defined(XILINX_LLTEMAC_BASEADDR4) || defined(XILINX_LLTEMAC_BASEADDR5) || \ > > + defined(XILINX_LLTEMAC_BASEADDR6) || defined(XILINX_LLTEMAC_BASEADDR7) > > +# define CONFIG_XILINX_LL_TEMAC 1 > > Why to do it in this way? I believe that the first lltemac driver will have XILINX_LLTEMAC_BASEADDR > and then others. Right, but we need a definitive agreement that it is so (Xilinx BSP generator). Did we them? If yes I will drop this part and insert your original condition (test only XILINX_LLTEMAC_BASEADDR). > But for all configurations if there is lltemac driver then will have anyone just BASEADDR. yep br, Stephan