From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 16 Nov 2020 20:16:55 +0100 Subject: [PATCH v3] env: mmc: Correct partition comparison in mmc_offset_try_partition In-Reply-To: <20201115172544.548-1-jigi.kim@gmail.com> References: <20201115172544.548-1-jigi.kim@gmail.com> Message-ID: <132937.1605554215@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Hoyeonjiki Kim, In message <20201115172544.548-1-jigi.kim@gmail.com> you wrote: > The function mmc_offset_try_partition searches the MMC partition for > locating environment data, by comparing the partition names with config > "u-boot,mmc-env-parition". However, it only compares the first word-size > bytes (size of 'const char *'), which may make the function to find > unintended partition. > > Correct the function not to partially compare the partition name with > config "u-boot,mmc-env-partition". > > Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition") > Signed-off-by: Hoyeonjiki Kim > Reviewed-by: Jaehoon Chung > Reviewed-by: Jorge Ramire-Ortiz > Reviewed-by: Wolfgang Denk > --- Reviewed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de God made the integers; all else is the work of Man. - Kronecker