From: htbegin <hotforest@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi: fix the incomplete erased status check in buffer write
Date: Sun, 19 Feb 2012 19:48:37 +0800 [thread overview]
Message-ID: <1329652117-14084-1-git-send-email-hotforest@gmail.com> (raw)
Without the fix, flash_write_cfibuffer will return timeout error
instead of not-erased error when all bytes in the first word of
a sector are 0xFF and other words are not.
Signed-off-by: htbegin <hotforest@gmail.com>
Cc: Stefan Roese <sr@denx.de>
---
drivers/mtd/cfi_flash.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 722c3fc..35294bc 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -873,7 +873,7 @@ static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp,
void *src = cp;
void *dst = (void *)dest;
void *dst2 = dst;
- int flag = 0;
+ int flag = 1;
uint offset = 0;
unsigned int shift;
uchar write_cmd;
@@ -898,7 +898,7 @@ static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp,
cnt = len >> shift;
- while ((cnt-- > 0) && (flag == 0)) {
+ while ((cnt-- > 0) && (flag == 1)) {
switch (info->portwidth) {
case FLASH_CFI_8BIT:
flag = ((flash_read8(dst2) & flash_read8(src)) ==
--
1.7.4.1
next reply other threads:[~2012-02-19 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 11:48 htbegin [this message]
2012-03-06 14:51 ` [U-Boot] [PATCH] cfi: fix the incomplete erased status check in buffer write Stefan Roese
2012-03-15 15:33 ` [U-Boot] [PATCH v2] " htbegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329652117-14084-1-git-send-email-hotforest@gmail.com \
--to=hotforest@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox