[U-Boot] [RFC v0 08/11] omap3: Consolidate UART information in omap3_common.h

Mike Frysinger
2012-04-03T21:35:25Z

On Thursday 22 March 2012 15:09:14 Tom Rini wrote:
> Unless a board defines CONFIG_SERIAL_MULTI we assume it is using an
> on-module UART somewhere. We leave the exact configuration per-board.
>
> Start an environment section in omap3_common.h and default to allowing
> the environment to override console/ethaddr. omap3_mvblx retains its
> behavior via opt-out.

not a big deal, but it seems like the env settings slipped in after the fact

> --- a/include/configs/omap3_common.h
> +++ b/include/configs/omap3_common.h
>
> +/*
> + * Default serial port configuration is an NS16550-compatible UART.
> + * Boards can override this as needed with CONFIG_SERIAL_MULTI
> + */
> +#ifndef CONFIG_SERIAL_MULTI
> +#define CONFIG_SYS_NS16550
> +#define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_REG_SIZE (-4)
> +#define CONFIG_SYS_NS16550_CLK 48000000
> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> + 115200}
> +#endif

the baudrate table is fairly independent of the serial driver. might want to
split that out into its own ifndef/define/endif check.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120403/59b060b2/attachment.pgp>