[U-Boot] [RFC v0 08/11] omap3: Consolidate UART information in omap3_common.h

Mike Frysinger
2012-04-04T02:42:38Z

On Tuesday 03 April 2012 19:45:11 Tom Rini wrote:
> On Tue, Apr 03, 2012 at 05:35:25PM -0400, Mike Frysinger wrote:
> > On Thursday 22 March 2012 15:09:14 Tom Rini wrote:
> > > --- a/include/configs/omap3_common.h
> > > +++ b/include/configs/omap3_common.h
> > >
> > > +/*
> > > + * Default serial port configuration is an NS16550-compatible UART.
> > > + * Boards can override this as needed with CONFIG_SERIAL_MULTI
> > > + */
> > > +#ifndef CONFIG_SERIAL_MULTI
> > > +#define CONFIG_SYS_NS16550
> > > +#define CONFIG_SYS_NS16550_SERIAL
> > > +#define CONFIG_SYS_NS16550_REG_SIZE (-4)
> > > +#define CONFIG_SYS_NS16550_CLK 48000000
> > > +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> > > + 115200}
> > > +#endif
> >
> > the baudrate table is fairly independent of the serial driver. might
> > want to split that out into its own ifndef/define/endif check.
>
> What I really wanted here was a test for "not using the SoM UART".
> Looking at the examples we have today, it's either the SoM and the above
> table but differing in which UART is physically exposed or it's
> SERIAL_MULTI and wants it's own baudrate table.

not sure what you mean. CONFIG_SYS_BAUDRATE_TABLE is used in
common/cmd_nvedit.c, so i'm not sure what you mean by having diff values
depending on the diff uart setups ...

> Part of me thinks I should whack at include/config_defaults.h and add
> something like #ifndef CONFIG_SYS_BAUDRATE_TABLE, standard rates,
> #endif. And same for CONFIG_SYS_PROMPT_HUSH_PS2 and probably a few
> others.

would make sense to me, although i'd cut out 4800 from the default list
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120403/f7ab5821/attachment.pgp>