public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] GCC47: Fix warning in md5.c
Date: Sun, 29 Apr 2012 00:28:40 +0200	[thread overview]
Message-ID: <1335652120-2646-2-git-send-email-marex@denx.de> (raw)
In-Reply-To: <1335652120-2646-1-git-send-email-marex@denx.de>

md5.c: In function ?MD5Final?:
md5.c:156:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
md5.c:157:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
 include/u-boot/md5.h |    5 ++++-
 lib/md5.c            |    4 ++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/u-boot/md5.h b/include/u-boot/md5.h
index 08924cc..e09c16a 100644
--- a/include/u-boot/md5.h
+++ b/include/u-boot/md5.h
@@ -11,7 +11,10 @@
 struct MD5Context {
 	__u32 buf[4];
 	__u32 bits[2];
-	unsigned char in[64];
+	union {
+		unsigned char in[64];
+		__u32 in32[16];
+	};
 };
 
 /*
diff --git a/lib/md5.c b/lib/md5.c
index 81a09e3..2ae4a06 100644
--- a/lib/md5.c
+++ b/lib/md5.c
@@ -153,8 +153,8 @@ MD5Final(unsigned char digest[16], struct MD5Context *ctx)
 	byteReverse(ctx->in, 14);
 
 	/* Append length in bits and transform */
-	((__u32 *) ctx->in)[14] = ctx->bits[0];
-	((__u32 *) ctx->in)[15] = ctx->bits[1];
+	ctx->in32[14] = ctx->bits[0];
+	ctx->in32[15] = ctx->bits[1];
 
 	MD5Transform(ctx->buf, (__u32 *) ctx->in);
 	byteReverse((unsigned char *) ctx->buf, 4);
-- 
1.7.10

  reply	other threads:[~2012-04-28 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28 22:28 [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c Marek Vasut
2012-04-28 22:28 ` Marek Vasut [this message]
2012-04-28 23:24   ` [U-Boot] [PATCH 2/2] GCC47: Fix warning in md5.c Mike Frysinger
2012-04-29 12:11 ` [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c Wolfgang Denk
2012-04-29 13:11   ` Marek Vasut
2012-04-29 18:08     ` Wolfgang Denk
2012-04-29 18:22       ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2012-04-28 22:24 Marek Vasut
2012-04-28 22:24 ` [U-Boot] [PATCH 2/2] GCC47: Fix warning in md5.c Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335652120-2646-2-git-send-email-marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox