From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA8DC433EF for ; Mon, 13 Sep 2021 13:03:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E1E56103B for ; Mon, 13 Sep 2021 13:03:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6E1E56103B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C871583956; Mon, 13 Sep 2021 15:03:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631538181; bh=KBQn6aYGv8N3f4CsnusIuDhYP8DJAU4OjSr0mWlPUqs=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pFDCYROfppn9N+lCVbjJdwsKNUD4ni7h2MF6KcIiVa1qJcRfGqRSw6uaUFhzi0S/Z x2CXJeeP82OB1c7jX/pAr9u8mfOKKV2/WuUkIV5eD4+QlkXyLN81//+GteBfW73V/F DvBAanSbxDY7Ns2bI+EYt3tCLmqkViPRP+9+0XETT87x8G7yhC75EfP7qLomcyEXl7 uBYtLWZJVMxG2FzPGLgs/R+Ozq5tsH6pBbF5nB8Psn0JCNxtId24PB+XNLKQiif0cC O34X3lxH/JokxSaxuenmaT9hwCdfI12Qw9fo82BX8JVUApvSCVi3JPfr/+AKRzsG8w JAShaKDvZioRQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E035583917 for ; Mon, 13 Sep 2021 15:02:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631538178; bh=KBQn6aYGv8N3f4CsnusIuDhYP8DJAU4OjSr0mWlPUqs=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=uizMujeyrCwWMNnIflnjsWcjV7x4OsFqpXhFYeScEd3YKSNcyOBTCzUAHL73puEF/ VQzReoiE+vUYHTo2qy+i61/mcXKYmdVDdQK6NbBrD35cJmkyiy8crVXFHQxIC3HzhQ f0+kXxVBdnK0HQQ3iMpK1MdSVzKlE0O2BvAxLB4p2fxax+1qIWVK04ASpSMPUr5S2R 1XFENfom7GuYhwXsGjyWnZkHcoWqnKvg0se4wYRRnHHieh84P04ZPN/jdzN3eAYErK 6Jupf2RdW/BbgU4P4oosHk6P1vqfI3Gcl34xrLNNU3genwxro6hW++B7xbsz8pYU01 AMCk9jqLcUFvg== Received: by janitor.denx.de (Postfix, from userid 108) id 72D4FA011E; Mon, 13 Sep 2021 15:02:58 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id EE18EA0036; Mon, 13 Sep 2021 15:02:50 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 9752E1E0AE8; Mon, 13 Sep 2021 15:02:50 +0200 (CEST) To: Pali =?utf-8?B?Um9ow6Fy?= cc: Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de From: Wolfgang Denk Subject: Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210913122245.my6ik4yjy7rwlh65@pali> References: <20210910204653.3066-1-pali@kernel.org> <1325940.1631529762@gemini.denx.de> <20210913110806.27hc36n6gmhw6uq4@pali> <1332387.1631535174@gemini.denx.de> <20210913122245.my6ik4yjy7rwlh65@pali> Comments: In-reply-to Pali =?utf-8?B?Um9ow6Fy?= message dated "Mon, 13 Sep 2021 14:22:45 +0200." Date: Mon, 13 Sep 2021 15:02:50 +0200 Message-ID: <1338201.1631538170@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Pali Rohár, In message <20210913122245.my6ik4yjy7rwlh65@pali> you wrote: > > Timeout is not too slow, but sometimes user is (when is interrupted by > other things during selecting file). And then it is not obvious why > sx/sb command is failing... compared to transfer via gkermit which do > not have this "problem". I see. > > > So... I do not know what is better if current behavior or this new which > > > changes UI interaction. > > > > We can do both, and still solve your problem: make the timeout > > adjustable so you can set it to something you can conveniently work > > with. > > Good point! env with timeout (or easier would be retry count?) seems > like a ideal solution how to "define" behavior without changing default > one. And e.g. negative value can mean infinite to support all possible > combinations. I would recommend to define a timeout (in seconds), this is easier to understand for the end user - without looking at the source code they cannot know how a retry count translates into a time interval. And yes, setting the timeout to 0 could mean it waits forever. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The optimum committee has no members. - Norman Augustine