[U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE

Albert ARIBAUD
2012-07-05T10:10:14Z

Hi Rob,

On Thu, 28 Jun 2012 08:54:10 -0500, Rob Herring <robherring2@gmail.com>
wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> CONFIG_STACKSIZE is not referenced anywhere except on AVR32, but
> present in most ARM boards. The IRQ and FIQ stacks are not setup in
> start.S, but arch/arm/lib/board.c, so also remove those comments.

Not sure I understand the last point. Can you clarify? How does this
relate to keeping FIQ / IRQ stack size declarations in config files?
E.g.:

> diff --git a/include/configs/SX1.h b/include/configs/SX1.h
> index ea09368..1c4f305 100644
> --- a/include/configs/SX1.h
> +++ b/include/configs/SX1.h
> @@ -141,10 +141,7 @@
>
> /*-----------------------------------------------------------------------
> * Stack sizes
> - *
> - * The stack sizes are set up in start.S using the settings below
> */
> -#define CONFIG_STACKSIZE (128*1024) /* regular stack */
> #ifdef CONFIG_USE_IRQ
> #define CONFIG_STACKSIZE_IRQ (4*1024) /* IRQ stack */
> #define CONFIG_STACKSIZE_FIQ (4*1024) /* FIQ stack */

These are kept, which seems to not match or explain the commit msg.

Amicalement,
--
Albert.