[U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE

Rob Herring
2012-07-05T21:31:15Z

Albert,

On 07/05/2012 05:10 AM, Albert ARIBAUD wrote:
> Hi Rob,
>
> On Thu, 28 Jun 2012 08:54:10 -0500, Rob Herring <robherring2@gmail.com>
> wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> CONFIG_STACKSIZE is not referenced anywhere except on AVR32, but
>> present in most ARM boards. The IRQ and FIQ stacks are not setup in
>> start.S, but arch/arm/lib/board.c, so also remove those comments.
>
> Not sure I understand the last point. Can you clarify? How does this
> relate to keeping FIQ / IRQ stack size declarations in config files?
> E.g.:

The irq and fiq stack sizes are setup in arch/arm/lib/board.c, not
start.S as the comment suggested.

There's only 2 boards that turn on USE_IRQ and I'm not convinced they
would actually work after a brief look. Perhaps we should just remove
all the defines except from those 2 boards.

Rob

>> diff --git a/include/configs/SX1.h b/include/configs/SX1.h
>> index ea09368..1c4f305 100644
>> --- a/include/configs/SX1.h
>> +++ b/include/configs/SX1.h
>> @@ -141,10 +141,7 @@
>>
>> /*-----------------------------------------------------------------------
>> * Stack sizes
>> - *
>> - * The stack sizes are set up in start.S using the settings below
>> */
>> -#define CONFIG_STACKSIZE (128*1024) /* regular stack */
>> #ifdef CONFIG_USE_IRQ
>> #define CONFIG_STACKSIZE_IRQ (4*1024) /* IRQ stack */
>> #define CONFIG_STACKSIZE_FIQ (4*1024) /* FIQ stack */
>
> These are kept, which seems to not match or explain the commit msg.
>
> Amicalement,
>