public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Liu Gang <Gang.Liu@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] powerpc/corenet_ds: Get rid of the SRIOBOOT_MASTER build target
Date: Thu, 9 Aug 2012 23:15:40 +0800	[thread overview]
Message-ID: <1344525340.2767.3.camel@linux> (raw)
In-Reply-To: <CAKWjMd7S-CQa+9sMrn+CLim82Y2spyb5YXouUh9YnBodA6Ndhw@mail.gmail.com>

On Wed, 2012-08-08 at 18:31 -0500, Andy Fleming wrote:
> On Thu, Jun 7, 2012 at 1:43 AM, Liu Gang <Gang.Liu@freescale.com> wrote:
> > Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
> > ---
> >  arch/powerpc/cpu/mpc85xx/cpu_init.c |   17 +++--
> >  arch/powerpc/cpu/mpc8xxx/srio.c     |  137 ++++++++++++-----------------------
> 
> 
> The change here (and in fsl_pci_init.c in another patch) causes
> horrible build breakage if you aren't building with the
> CONFIG_SRIO_PCIE_BOOT_SLAVE option.
> 
> Please rework so that you can build *without* that option!
> 
> Andy
> 

Hi, Andy,
Thanks a lot for your comment.
You are right, there will be build breakage when building the
non-corenet platform.
I have resolved this issue in v2 and have sent the new patches
to open source.
Please help to check.

Thanks!
Best Regards,
Liu Gang

  reply	other threads:[~2012-08-09 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  6:43 [U-Boot] [PATCH 1/6] powerpc/corenet_ds: Update README.srio-boot-corenet Liu Gang
2012-06-07  6:43 ` [U-Boot] [PATCH 2/6] powerpc/corenet_ds: Get rid of the SRIOBOOT_MASTER build target Liu Gang
2012-08-08 23:31   ` Andy Fleming
2012-08-09 15:15     ` Liu Gang [this message]
2012-08-14  9:37       ` Liu Gang
2012-06-07  6:43 ` [U-Boot] [PATCH 3/6] powerpc/corenet_ds: Get rid of the CONFIG_SRIOBOOT_SLAVE_PORTx macro Liu Gang
2012-06-07  6:43 ` [U-Boot] [PATCH 4/6] powerpc/corenet_ds: Update README and README.srio-pcie-boot-corenet Liu Gang
2012-06-07  6:43 ` [U-Boot] [PATCH 5/6] powerpc/corenet_ds: Master module for boot from PCIE Liu Gang
2012-06-07  6:43 ` [U-Boot] [PATCH 6/6] powerpc/corenet_ds: Slave " Liu Gang
2012-08-07  6:40 ` [U-Boot] [PATCH 1/6] powerpc/corenet_ds: Update README.srio-boot-corenet Liu Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344525340.2767.3.camel@linux \
    --to=gang.liu@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox