From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Makefile: fix HAVE_VENDOR_COMMON_LIB
Date: Tue, 14 Aug 2012 13:44:29 +0200 [thread overview]
Message-ID: <1344944669-18062-1-git-send-email-daniel.schwierzeck@gmail.com> (raw)
In-Reply-To: <20120814005014.GA13432@tyr.buserror.net>
From: Scott Wood <scottwood@freescale.com>
Commit 8b5a02640adf77301f943e8754992c50df004e8a ("Makefile: cosmetic:
optimize usage of LIBS-y") broke the build of boards that have a board
vendor "common" directory, by introducing a space between "LIBS-" and
"y".
Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
Changes vor v2:
- fix the wrong spaces also in spl/Makefile
Tested with:
MAKEALL spear600
MAKEALL -s omap3
MAKEALL -s omap4
---
Makefile | 2 +-
spl/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 5ce5cc3..947f3ff 100644
--- a/Makefile
+++ b/Makefile
@@ -225,7 +225,7 @@ endif
OBJS := $(addprefix $(obj),$(OBJS))
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n)
+HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
LIBS-y += lib/libgeneric.o
LIBS-y += lib/lzma/liblzma.o
diff --git a/spl/Makefile b/spl/Makefile
index e9ecb9b..2cf7bda 100644
--- a/spl/Makefile
+++ b/spl/Makefile
@@ -23,7 +23,7 @@ include $(TOPDIR)/config.mk
# We want the final binaries in this directory
obj := $(OBJTREE)/spl/
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard $(SRCTREE)/board/$(VENDOR)/common/Makefile), y, n)
+HAVE_VENDOR_COMMON_LIB = $(if $(wildcard $(SRCTREE)/board/$(VENDOR)/common/Makefile),y,n)
ifdef CONFIG_SPL_START_S_PATH
START_PATH := $(subst ",,$(CONFIG_SPL_START_S_PATH))
--
1.7.11.3
next prev parent reply other threads:[~2012-08-14 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 0:50 [U-Boot] [PATCH] Makefile: fix HAVE_VENDOR_COMMON_LIB Scott Wood
2012-08-14 11:44 ` Daniel Schwierzeck [this message]
2012-08-15 1:12 ` [U-Boot] [PATCH v2] " Kim Phillips
2012-08-17 16:18 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344944669-18062-1-git-send-email-daniel.schwierzeck@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox