public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 03/12] SPL: Add option to skip copying of the mkimage header
Date: Mon, 27 Aug 2012 12:50:58 +0200	[thread overview]
Message-ID: <1346064667-29692-4-git-send-email-sr@denx.de> (raw)
In-Reply-To: <1346064667-29692-1-git-send-email-sr@denx.de>

On some system (e.g. powerpc), the load-address and entry-point is
located at address 0. So the current approach to load the image
(payload) including the header to the address "load-address - 64"
can't work here.

This patch adds an flag to skip this copying including header to
the SPL framework. By setting SPL_COPY_PAYLOAD_ONLY, only the
playload will be copied. This will be used by the SPL NOR flash
driver on powerpc.

Signed-off-by: Stefan Roese <sr@denx.de>
---

 common/spl/spl.c | 21 +++++++++++++++++----
 include/spl.h    |  3 +++
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index cc8df84..13bebbc 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -76,10 +76,23 @@ void spl_parse_image_header(const struct image_header *header)
 	u32 header_size = sizeof(struct image_header);
 
 	if (image_get_magic(header) == IH_MAGIC) {
-		spl_image.size = image_get_data_size(header) + header_size;
-		spl_image.entry_point = image_get_load(header);
-		/* Load including the header */
-		spl_image.load_addr = spl_image.entry_point - header_size;
+		if (spl_image.flags & SPL_COPY_PAYLOAD_ONLY) {
+			/*
+			 * On some system (e.g. powerpc), the load-address and
+			 * entry-point is located at address 0. We can't load
+			 * to 0-0x40. So skip header in this case.
+			 */
+			spl_image.load_addr = image_get_load(header);
+			spl_image.entry_point = image_get_ep(header);
+			spl_image.size = image_get_data_size(header);
+		} else {
+			spl_image.entry_point = image_get_load(header);
+			/* Load including the header */
+			spl_image.load_addr = spl_image.entry_point -
+				header_size;
+			spl_image.size = image_get_data_size(header) +
+				header_size;
+		}
 		spl_image.os = image_get_os(header);
 		spl_image.name = image_get_name(header);
 		debug("spl: payload image: %s load addr: 0x%x size: %d\n",
diff --git a/include/spl.h b/include/spl.h
index 478aa10..673c4a4 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -38,8 +38,11 @@ struct spl_image_info {
 	u32 load_addr;
 	u32 entry_point;
 	u32 size;
+	u32 flags;
 };
 
+#define SPL_COPY_PAYLOAD_ONLY	1
+
 extern struct spl_image_info spl_image;
 extern u32 *boot_params_ptr;
 extern gd_t gdata;
-- 
1.7.12

  parent reply	other threads:[~2012-08-27 10:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27 10:50 [U-Boot] [PATCH v2 0/12] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-27 10:50 ` [U-Boot] [PATCH v2 01/12] SPL: Fix build problems on ARM with new SPL framework Stefan Roese
2012-08-27 16:30   ` Tom Rini
2012-08-27 10:50 ` [U-Boot] [PATCH v2 02/12] SPL: Use image_get_xxx() functions to access header values Stefan Roese
2012-08-27 16:31   ` Tom Rini
2012-08-27 10:50 ` Stefan Roese [this message]
2012-08-27 10:50 ` [U-Boot] [PATCH v2 04/12] SPL: Add NOR flash booting support Stefan Roese
2012-08-27 16:45   ` Tom Rini
2012-08-27 17:29   ` Daniel Schwierzeck
2012-08-27 17:59     ` Tom Rini
2012-08-28  8:32       ` Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 05/12] powerpc: Extract EPAPR_MAGIC constants into processor.h Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 06/12] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-27 16:27   ` Tom Rini
2012-08-28  8:21     ` Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 07/12] env: Extract getenv_f() into separate source file Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 08/12] mpc5200: Add SPL support Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 09/12] mpc5200: Add a3m071 board support Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 10/12] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup" Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 11/12] Makefile: Add possibility to set entry-point for u-boot.img Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 12/12] Makefile: Add target for combined spl/u-boot.bin & u-boot.img Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346064667-29692-4-git-send-email-sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox