public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] usb: ulpi: add indicator configuration function
Date: Thu, 06 Sep 2012 02:06:57 +0200	[thread overview]
Message-ID: <1346890017.1487.37.camel@tellur> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F379E0065C9@HQMAIL04.nvidia.com>

Hi Tom,

Am Mittwoch, den 05.09.2012, 09:25 -0700 schrieb Tom Warren:
> Igor/Marek,
> 
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Wednesday, September 05, 2012 1:52 AM
> > To: Igor Grinberg
> > Cc: Lucas Stach; u-boot at lists.denx.de; Stephen Warren; Tom Warren
> > Subject: Re: [PATCH v2 4/5] usb: ulpi: add indicator configuration function
> > 
> > Dear Igor Grinberg,
> > 
> > > Hi Lucas, Tom,
> > >
> > > I'm sorry for the late reply.
> > > I understand, that Tom has already applied this to tegra/next, but as
> > > the changes/follow up patches are required, may be we can do this in
> > > another fashion...
> > >
> > > 1) Thanks for the patch and working on extending the generic framework!
> > > 2) This patch has no dependencies on tegra specific patches, so
> > >    I think, it should go through Marex usb tree, but doing this will
> > >    require the right merge order, so bisectability will not suffer.
> > >    So, Marek, Tom, you should decide which way is fine with you both.
> 
> I'm not sure how the USB and Tegra repos can coordinate on patches like this, since I don't pull from/rebase against USB, and AFAIK Marek doesn't reference Tegra when he updates his repo. I'm a sub-repo of ARM, which is a sub-repo of TOT (u-boot/master). What I usually do (and have always done) is to take the entire patchset that includes a Tegra component (USB, mmc, SPI, etc.) and hope (pray?) that anyone merging my changes upstream of me will be able to resolve the conflicts/pre-existing patches. So far, I haven't heard from anyone (Albert or Wolfgang) that's had a problem with that, perhaps because it's pretty rare. AFAICT, there's no other procedure outlined in the U-Boot wiki custodian's page.  If there's a better procedure I should be following, let's get it documented and I'll be glad to hew to the line. I'm still on the learning curve for git merging, rebasing, etc.
> 
I thought about how we could merge all this without loosing our sanity.
I've already wrote this a bit hidden in a reply to the multi controller
thread: I think it's best to handle all USB related changes through the
u-boot-usb tree, as all this stuff should really be under drivers/usb.

This means: I'll split out the clock output related changes, so they can
go in the Tegra tree. Everything touching USB goes into the u-boot-usb
tree and I'll rebase my changes accordingly. This also means commit "dm:
Tegra: Staticize local functions" should be removed from the Tegra tree
and move over to the USB tree.

This way we won't get any build breakages and there should be no merge
conflicts. It also opens the possibility to move the Tegra USB
implementation to the right location in the source tree a bit later in
this cycle, without messing up the merge.

Thanks,
Lucas

  reply	other threads:[~2012-09-06  0:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 20:18 [U-Boot] [PATCH v2 0/5] Tegra 2 USB ULPI series Lucas Stach
2012-08-21 20:18 ` [U-Boot] [PATCH v2 1/5] tegra20: complete periph_id enum Lucas Stach
2012-08-21 20:18 ` [U-Boot] [PATCH v2 2/5] tegra20: add clock_set_pllout function Lucas Stach
2012-08-21 20:18 ` [U-Boot] [PATCH v2 3/5] usb: fix ulpi_set_vbus prototype Lucas Stach
2012-08-21 20:18 ` [U-Boot] [PATCH v2 4/5] usb: ulpi: add indicator configuration function Lucas Stach
2012-09-05  7:52   ` Igor Grinberg
2012-09-05  8:51     ` Marek Vasut
2012-09-05 16:25       ` Tom Warren
2012-09-06  0:06         ` Lucas Stach [this message]
2012-09-07  0:11           ` Marek Vasut
2012-08-21 20:18 ` [U-Boot] [PATCH v2 5/5] tegra20: add USB ULPI init code Lucas Stach
2012-09-05  8:22   ` Igor Grinberg
2012-08-23 18:42 ` [U-Boot] [PATCH v2 0/5] Tegra 2 USB ULPI series Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346890017.1487.37.camel@tellur \
    --to=dev@lynxeye.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox