From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
Date: Mon, 17 Sep 2012 19:06:40 -0500 [thread overview]
Message-ID: <1347926800.19543.22@snotra> (raw)
In-Reply-To: <201209180201.40032.marex@denx.de> (from marex@denx.de on Mon Sep 17 19:01:39 2012)
On 09/17/2012 07:01:39 PM, Marek Vasut wrote:
> Dear Scott Wood,
>
> > On Thu, Aug 30, 2012 at 01:39:38PM -0000, Marek Vasut wrote:
> > > This is based on Linux kernel -next:
> > >
> > > commit a1256b0e087ed3cdb584c683acb966ee885f733c
> > > Author: Brian Norris <computersforpeace@gmail.com>
> > > Date: Fri Jul 13 09:28:24 2012 -0700
> > >
> > > mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
> > >
> > > The NAND_CHIPOPTIONS_MSK has limited utility and is causing
> real
> > > bugs. It silently masks off at least one flag that might be
> set by
> > > the driver (NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND
> driver
> > > and possibly others.
> > >
> > > Really, as long as driver writers exercise a small amount of
> care
> > > with NAND_* options, this mask is not necessary at all; it
> was only
> > > here to prevent certain options from accidentally being set
> by the
> > > driver. But the original thought turns out to be a bad idea
> > > occasionally. Thus, kill it.
> > >
> > > Note, this patch fixes some major gpmi-nand breakage.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Brian Norris <computersforpeace@gmail.com>
> > > Cc: Eric Nelson <eric.nelson@boundarydevices.com>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Otavio Salvador <otavio@ossystems.com.br>
> > > Cc: Scott Wood <scottwood@freescale.com>
> >
> > Applied to u-boot-nand-flash with the SHA1 updated based on current
> > linux-next: 14f44abf1dafc20ba42ce8616a8fc8fbd1b3712b
>
> Thanks ... I think the sha1 is irrelevant as next is being constantly
> rebased
> anyway :/
They're at -rc6 or so, so maybe this'll be the final one. :-)
The SHA1 should only change if the tree it was pulled from got rebased.
> btw. this should definitelly go to current release.
Yes.
-Scott
prev parent reply other threads:[~2012-09-18 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 23:39 [U-Boot] [PATCH] mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver Marek Vasut
2012-08-30 23:45 ` Marek Vasut
2012-09-01 20:24 ` Stefano Babic
2012-09-01 20:27 ` Marek Vasut
2012-09-17 23:55 ` [U-Boot] " Scott Wood
2012-09-18 0:01 ` Marek Vasut
2012-09-18 0:06 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347926800.19543.22@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox