From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile
Date: Wed, 19 Sep 2012 18:36:34 -0500 [thread overview]
Message-ID: <1348097794.22800.20@snotra> (raw)
In-Reply-To: <505A55D1.9070807@ti.com> (from trini@ti.com on Wed Sep 19 18:31:29 2012)
On 09/19/2012 06:31:29 PM, Tom Rini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 09/19/12 15:39, Scott Wood wrote:
> > On 09/19/2012 06:25:26 AM, Jos? Miguel Gon?alves wrote:
> >> Samsung's S3C24XX SoCs need this in order to generate a binary
> >> image with a padded SPL concatenated with U-Boot.
> >>
> >> Signed-off-by: Jos? Miguel Gon?alves <jose.goncalves@inov.pt>
> >> --- Changes for v2: - None
> >>
> >> Changes for v3: - Changed new binary target name from
> >> u-boot-ubl.bin to u-boot-pad.bin
> >>
> >> Changes for v4: - None --- Makefile | 11 ++++++----- 1 file
> >> changed, 6 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/Makefile b/Makefile index 8738d55..86dedca 100644
> >> --- a/Makefile +++ b/Makefile @@ -433,14 +433,15 @@
> >> $(obj)u-boot.sha1: $(obj)u-boot.bin $(obj)u-boot.dis:
> >> $(obj)u-boot $(OBJDUMP) -d $< > $@
> >>
> >> -$(obj)u-boot.ubl: $(obj)spl/u-boot-spl.bin
> >> $(obj)u-boot.bin +$(obj)u-boot-pad.bin:
> >> $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin $(OBJCOPY) ${OBJCFLAGS}
> >> --pad-to=$(PAD_TO) -O binary $(obj)spl/u-boot-spl
> >> $(obj)spl/u-boot-spl-pad.bin - cat
> >> $(obj)spl/u-boot-spl-pad.bin $(obj)u-boot.bin >
> >> $(obj)u-boot-ubl.bin - $(obj)tools/mkimage -n
> >> $(UBL_CONFIG) -T ublimage \ - -e $(CONFIG_SYS_TEXT_BASE)
> >> -d $(obj)u-boot-ubl.bin $(obj)u-boot.ubl - rm
> >> $(obj)u-boot-ubl.bin + cat $(obj)spl/u-boot-spl-pad.bin
> >> $(obj)u-boot.bin > $(obj)u-boot-pad.bin rm
> >> $(obj)spl/u-boot-spl-pad.bin
> >
> > This rule lists u-boot-spl.bin as a prerequisite, but it doesn't
> > appear to use it -- it uses u-boot-spl instead.
> >
> > It seems that either spl/Makefile should produce u-boot-spl rather
> > than u-boot-spl.bin and let the toplevel Makefile deal with
> > converting it to a binary, or spl/Makefile should take care of
> > adding any needed padding for the target and the final rule should
> > just be a concatenation.
>
> So, if we use a weak PAD_TO value of say 0x1, we could always "pad"
> u-boot-spl.bin out and then do the concatenation here and in a few
> other targets as well.
Yes, or use a variable that includes the linker option, so that it
expands to an empty string if padding isn't required.
-Scott
next prev parent reply other threads:[~2012-09-19 23:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:25 [U-Boot] [PATCH v4 00/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 01/11] Add configuration option to select printf() inclusion on SPL José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 03/11] serial: Add support to 4 ports in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 05/11] serial: Remove unnecessary delay in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 06/11] rtc: Improve rtc_get() on s3c24x0_rtc José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 07/11] rtc: Fix rtc_reset() " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 08/11] rtc: Don't allow setting unsuported years " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver José Miguel Gonçalves
2012-09-19 16:19 ` Scott Wood
2012-09-19 16:34 ` José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile José Miguel Gonçalves
2012-09-19 16:10 ` Scott Wood
2012-09-19 16:58 ` José Miguel Gonçalves
2012-09-19 17:08 ` Scott Wood
2012-09-19 17:40 ` José Miguel Gonçalves
2012-09-19 17:11 ` Stephen Warren
2012-09-19 18:19 ` Tom Rini
2012-09-19 18:36 ` Scott Wood
2012-09-19 20:17 ` Tom Rini
2012-09-19 18:44 ` José Miguel Gonçalves
2012-09-19 22:39 ` Scott Wood
2012-09-19 23:31 ` Tom Rini
2012-09-19 23:36 ` Scott Wood [this message]
2012-09-19 23:40 ` Tom Rini
2012-09-20 0:38 ` José Miguel Gonçalves
2012-09-20 1:29 ` Tom Rini
2012-09-20 16:01 ` Tom Warren
2012-09-20 16:23 ` Tom Rini
2012-09-20 16:32 ` Tom Warren
2012-09-20 18:09 ` Scott Wood
2012-09-21 1:08 ` José Miguel Gonçalves
2012-09-21 5:43 ` Wolfgang Denk
2012-09-21 8:13 ` José Miguel Gonçalves
2012-09-21 15:52 ` Wolfgang Denk
2012-09-21 16:08 ` Marek Vasut
2012-09-21 16:13 ` Tom Rini
2012-09-21 16:26 ` José Miguel Gonçalves
2012-09-21 16:38 ` Tom Rini
2012-09-21 16:37 ` Langer Thomas
2012-09-21 18:33 ` Scott Wood
2012-09-21 18:43 ` Marek Vasut
2012-09-21 19:03 ` Scott Wood
2012-09-21 19:24 ` Marek Vasut
2012-09-21 19:33 ` Scott Wood
2012-09-23 16:25 ` Wolfgang Denk
2012-09-19 11:25 ` [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 19:18 ` Tom Rini
2012-09-19 20:34 ` José Miguel Gonçalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348097794.22800.20@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox