From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 24 Sep 2012 13:47:27 -0500 Subject: [U-Boot] [RFC PATCH 03/17] powerpc: remove .fixup test In-Reply-To: <1348500648.2514.2.camel@petert> (from ptyser@xes-inc.com on Mon Sep 24 10:30:48 2012) Message-ID: <1348512447.25867.10@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/24/2012 10:30:48 AM, Peter Tyser wrote: > Hi Scott, > > On Fri, 2012-09-21 at 19:01 -0500, Scott Wood wrote: > > This was introduced by commit > 244615197469dd6fe75ae082f38424b97c79aeaf, but it > > fails in a minimal SPL build where the only thing in > arch/powerpc/lib is > > cache.c, which apparently doesn't generate any fixup records. > > > > If this check is really still needed, it should be moved somewhere > more > > appropriate, but given that it's been three years and no other > > architecture does a test like this, I think we can remove it. It > would > > have been nice if the original commit said how old the problematic > > toolchains were. > > There was a discussion about it a long while back that has some > version > information: > http://www.mail-archive.com/u-boot at lists.denx.de/msg21415.html > > Based on my testing I only could reproduce the issue with 3.x > versions, > which are 7+ years old. So do you think we still need this check (moved to someplace we can be sure will generate fixups), or is it time to remove it? -Scott