From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 14/17] spl: introduce CONFIG_SPL_TARGET
Date: Mon, 24 Sep 2012 15:05:51 -0500 [thread overview]
Message-ID: <1348517151.25867.17@snotra> (raw)
In-Reply-To: <20120924190304.GH1797@bill-the-cat> (from trini@ti.com on Mon Sep 24 14:03:04 2012)
On 09/24/2012 02:03:04 PM, Tom Rini wrote:
> On Mon, Sep 24, 2012 at 01:54:05PM -0500, Scott Wood wrote:
> > On 09/21/2012 07:12:38 PM, Tom Rini wrote:
> > >On Fri, Sep 21, 2012 at 07:01:24PM -0500, Scott Wood wrote:
> > >
> > >> Currently it seems that SPLs rely on the user to specify the
> > >final target
> > >> on the make command line. This is a departure from traditional
> > >U-Boot practice
> > >> and results in a lack of build coverage in MAKEALL.
> > >>
> > >> Now boards can specify CONFIG_SPL_TARGET to determine what gets
> > >built by default.
> > >> Eventually all SPL boards should specify CONFIG_SPL_TARGET, but
> > >for now default
> > >> to at least building the SPL code.
> > >>
> > >> Signed-off-by: Scott Wood <scottwood@freescale.com>
> > >
> > >Note that this is sometimes handled via config.mk fragments:
> > >ifdef CONFIG_SPL_BUILD
> > >ALL-y += $(OBJTREE)/MLO
> > >else
> > >ALL-y += $(obj)u-boot.img
> > >endif
> > >
> > >Or similar. I don't know what's better.
> >
> > Ah. I was wondering if there were some magic that existing boards
> > were using, but couldn't find it.
> >
> > I think I'd prefer having a simple CONFIG_SPL_TARGET, and boards
> > that need something more complicated can still provide a config.mk
> > fragment. What is the CONFIG_SPL_BUILD test for? Is ALL-y really
> > evaluated twice?
>
> I'm not sure. And thinking about what Wolfgang said in the other
> thread
> about SoC specific Makefile fragment for the custom rules, it might
> work
> out easily enough to convert things like this.
Right, s/boards/SoCs/
> And yes, unless I'm
> missing something, we evaulate everything again for the SPL build (and
> each side of that if/else only would make sense in that context).
OK, it's not that you evaluate everything (most makefiles, yes, but I
don't think this applies to the toplevel makefile) so much as that
spl/Makefile has its own ALL-y.
-Scott
next prev parent reply other threads:[~2012-09-24 20:05 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 0:01 [U-Boot] [RFC PATCH 00/17] Convert p1_p2_rdb_pc to new spl Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 01/17] Add u-boot-pad.bin target to the Makefile Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 02/17] spl: rename u-boot-pad.bin to u-boot-with-spl.bin Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 03/17] powerpc: remove .fixup test Scott Wood
2012-09-24 15:30 ` Peter Tyser
2012-09-24 18:47 ` Scott Wood
2012-09-24 23:38 ` Tom Rini
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 04/17] powerpc/mpc85xx: fix TLB alignment Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 05/17] powerpc/mpc8xxx: move LAW code into arch/powerpc/cpu/mpc8xxx Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 06/17] spl/mpc85xx: move udelay to cpu code Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 07/17] spl: include resetvec and lib8xxx Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 08/17] spl/powerpc: introduce CONFIG_SPL_INIT_MINIMAL Scott Wood
2012-09-24 23:48 ` Tom Rini
2012-09-24 23:52 ` Scott Wood
2012-09-25 0:03 ` Tom Rini
2012-09-25 0:17 ` Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 09/17] spl/85xx: new SPL support Scott Wood
2012-09-24 23:51 ` Tom Rini
2012-09-24 23:54 ` Scott Wood
2012-09-25 0:04 ` Tom Rini
2012-09-25 0:08 ` Scott Wood
2012-09-25 0:13 ` Tom Rini
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 10/17] powerpc/p1_p2_rdb_pc: " Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 11/17] spl/nand: introduce CONFIG_SPL_NAND_MINIMAL Scott Wood
2012-09-24 23:55 ` Tom Rini
2012-09-25 0:02 ` Scott Wood
2012-09-25 0:13 ` Tom Rini
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 12/17] spl/nand: config symbol documentation Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 13/17] spl/nand: Add minimal-spl driver for Freescale eLBC NAND Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 14/17] spl: introduce CONFIG_SPL_TARGET Scott Wood
2012-09-22 0:12 ` Tom Rini
2012-09-24 18:54 ` Scott Wood
2012-09-24 19:03 ` Tom Rini
2012-09-24 20:05 ` Scott Wood [this message]
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 15/17] p1_p2_rdb_pc: convert from nand_spl to new spl Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 16/17] powerpc/mpc85xx/p2020rdb-pc: fix SPL DDR config Scott Wood
2012-09-22 0:01 ` [U-Boot] [RFC PATCH 17/17] ns16550: wait for TENT before initializing Scott Wood
2012-10-01 14:27 ` [U-Boot] [u-boot-release] " Timur Tabi
2012-09-22 0:13 ` [U-Boot] [RFC PATCH 00/17] Convert p1_p2_rdb_pc to new spl Tom Rini
2012-09-24 18:50 ` Scott Wood
2012-09-24 19:06 ` Tom Rini
2012-09-24 19:15 ` Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 00/22] " Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 01/22] serial/ns16550: don't build serial_ns16550 with MIN_FUNCTIONS Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 02/22] serial/ns16550: wait for TEMT before initializing Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 03/22] powerpc/mpc85xx: move debug tlb entry after TLB is in known state Scott Wood
2012-10-30 9:26 ` Prabhakar Kushwaha
2012-10-30 21:07 ` Scott Wood
2012-10-31 6:17 ` Prabhakar Kushwaha
2012-10-31 22:08 ` Scott Wood
2012-10-31 22:44 ` McClintock Matthew-B29882
[not found] ` <CAEsOVNeZAyH1nxfgnjPYUG4=7yxjF9rjsRWrpa=WYW8edfiM3Q@mail.gmail.com>
2012-10-31 22:45 ` McClintock Matthew-B29882
2012-10-31 22:51 ` Scott Wood
2012-11-16 2:12 ` Scott Wood
2012-11-26 20:53 ` Andy Fleming
2012-10-30 2:04 ` [U-Boot] [PATCH v2 04/22] powerpc/mpc85xx: add comma before "already enabled" Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 05/22] Add u-boot-pad.bin target to the Makefile Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 06/22] spl: rename u-boot-pad.bin to u-boot-with-spl.bin Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 07/22] spl: introduce CONFIG_SPL_TARGET Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 08/22] powerpc: change .fixup test to a GCC version test Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 09/22] powerpc/mpc85xx: fix TLB alignment Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 10/22] powerpc/mpc8xxx: move LAW code into arch/powerpc/cpu/mpc8xxx Scott Wood
2012-10-30 2:04 ` [U-Boot] [PATCH v2 11/22] spl/mpc85xx: move udelay to cpu code Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 12/22] spl: include resetvec and lib8xxx Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 13/22] spl/mpc85xx: rename cpu_init_nand.c to spl_minimal.c Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 14/22] powerpc/mpc85xx: consistently use COBJS-y Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 15/22] spl/powerpc: introduce CONFIG_SPL_INIT_MINIMAL Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 16/22] spl/85xx: new SPL support Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 17/22] powerpc/mpc85xx/p1_p2_rdb_pc: " Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 18/22] spl/nand: introduce CONFIG_SPL_NAND_DRIVERS, _BASE, and _ECC Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 19/22] spl/nand: config symbol documentation Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 20/22] powerpc/mpc85xx/p1_p2_rdb_pc: convert from nand_spl to new spl Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 21/22] powerpc/mpc85xx/p1_p2_rdb_pc: clean up memory map Scott Wood
2012-10-30 2:05 ` [U-Boot] [PATCH v2 22/22] powerpc/mpc85xx/p2020rdb-pca: Use L2 SRAM for SPL boot Scott Wood
2012-10-30 3:17 ` Tabi Timur-B04825
2012-10-30 23:37 ` Scott Wood
2012-11-13 22:41 ` [U-Boot] [PATCH v3] " Scott Wood
2012-10-30 17:04 ` [U-Boot] [PATCH v2 00/22] Convert p1_p2_rdb_pc to new spl Tom Rini
2012-10-30 20:17 ` Scott Wood
2012-10-30 21:12 ` Tom Rini
2012-11-13 22:42 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348517151.25867.17@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox