From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 24 Sep 2012 18:52:40 -0500 Subject: [U-Boot] [RFC PATCH 08/17] spl/powerpc: introduce CONFIG_SPL_INIT_MINIMAL In-Reply-To: <20120924234828.GL1797@bill-the-cat> (from trini@ti.com on Mon Sep 24 18:48:28 2012) References: <1348272087-29608-1-git-send-email-scottwood@freescale.com> <1348272087-29608-9-git-send-email-scottwood@freescale.com> <20120924234828.GL1797@bill-the-cat> Message-ID: <1348530760.25867.27@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/24/2012 06:48:28 PM, Tom Rini wrote: > On Fri, Sep 21, 2012 at 07:01:18PM -0500, Scott Wood wrote: > > > Signed-off-by: Scott Wood > [snip] > > diff --git a/arch/powerpc/cpu/mpc85xx/Makefile > b/arch/powerpc/cpu/mpc85xx/Makefile > > index 33e93c8..c51a774 100644 > > --- a/arch/powerpc/cpu/mpc85xx/Makefile > > +++ b/arch/powerpc/cpu/mpc85xx/Makefile > > @@ -28,7 +28,25 @@ include $(TOPDIR)/config.mk > > > > LIB = $(obj)lib$(CPU).o > > > > +MINIMAL= > > + > > +ifdef CONFIG_SPL_BUILD > > +ifdef CONFIG_SPL_INIT_MINIMAL > > +MINIMAL=y > > +endif > > +endif > > + > > +ifdef MINIMAL > > + > > +START = start.o resetvec.o > > + > > +COBJS-y += cpu_init_early.o tlb.o > > +COBJS-$(CONFIG_SPL_NAND_MINIMAL) += cpu_init_nand.o > > + > > +else > > So, maybe it's just personal preference by why not: > START = start.o resetvec.o > ifdef CONFIG_SPL_BUILD > COBJS-$(CONFIG_SPL_INIT_MINIMAL) += cpu_init_early.o tlb.o > COBJS-$(CONFIG_SPL_NAND_MINIMAL) += cpu_init_nand.o > else > .... The START line could be factored out, but I don't think the rest works -- where would non-minimal SPL pull in its files? -Scott