From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci: don't print debug output
Date: Thu, 27 Sep 2012 22:02:21 +0200 [thread overview]
Message-ID: <1348776141.1432.21.camel@tellur> (raw)
In-Reply-To: <201208301747.19631.marex@denx.de>
Hi Marek,
Am Donnerstag, den 30.08.2012, 17:47 +0200 schrieb Marek Vasut:
> Dear Lucas Stach,
>
> > This is clearly some sort of debug output and should not
> > be printed during normal operation.
> >
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
>
> I think we should apply this ... yet it's been in uboot for so long, so I'd like
> to hear other people opinion :)
>
Any updates on this one? Seems nobody really cares and it uglyfies
output in the multi controller case a lot, so I really wish to see this
gone.
> > ---
> > drivers/usb/host/ehci-hcd.c | 2 +-
> > 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 2f4fa5e..eb9e323 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
> >
> > reg = ehci_readl(&hccr->cr_hcsparams);
> > descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
> > - printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> > + debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> > /* Port Indicators */
> > if (HCS_INDICATOR(reg))
> > descriptor.hub.wHubCharacteristics |= 0x80;
>
> Best regards,
> Marek Vasut
>
Thanks,
Lucas
prev parent reply other threads:[~2012-09-27 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 15:38 [U-Boot] [PATCH] usb: ehci: don't print debug output Lucas Stach
2012-08-30 15:47 ` Marek Vasut
2012-09-27 20:02 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348776141.1432.21.camel@tellur \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox