From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 4/9] fsl_sata: Make sata_{read, write}() comply with <part.h>
Date: Sat, 29 Sep 2012 13:51:51 -0700 [thread overview]
Message-ID: <1348951916-3495-5-git-send-email-trini@ti.com> (raw)
In-Reply-To: <1348951916-3495-1-git-send-email-trini@ti.com>
- sata_write() takes a const void as the last argument. Fixing this
means we also need to make ata_low_level_rw_lba{28,48} also take a
const void.
- Both sata_{read,write} take lbaint_t for blkcnt and ulong for blknr
Signed-off-by: Tom Rini <trini@ti.com>
---
drivers/block/fsl_sata.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c
index 3026ade..ed4647f 100644
--- a/drivers/block/fsl_sata.c
+++ b/drivers/block/fsl_sata.c
@@ -758,7 +758,8 @@ static int fsl_sata_get_flush_ext(int dev)
return sata->flush_ext;
}
-u32 ata_low_level_rw_lba48(int dev, u32 blknr, u32 blkcnt, void *buffer, int is_write)
+u32 ata_low_level_rw_lba48(int dev, u32 blknr, lbaint_t blkcnt,
+ const void *buffer, int is_write)
{
u32 start, blks;
u8 *addr;
@@ -792,7 +793,8 @@ u32 ata_low_level_rw_lba48(int dev, u32 blknr, u32 blkcnt, void *buffer, int is_
return blkcnt;
}
-u32 ata_low_level_rw_lba28(int dev, u32 blknr, u32 blkcnt, void *buffer, int is_write)
+u32 ata_low_level_rw_lba28(int dev, u32 blknr, u32 blkcnt, const void *buffer,
+ int is_write)
{
u32 start, blks;
u8 *addr;
@@ -823,7 +825,7 @@ u32 ata_low_level_rw_lba28(int dev, u32 blknr, u32 blkcnt, void *buffer, int is_
/*
* SATA interface between low level driver and command layer
*/
-ulong sata_read(int dev, u32 blknr, u32 blkcnt, void *buffer)
+ulong sata_read(int dev, ulong blknr, lbaint_t blkcnt, void *buffer)
{
u32 rc;
fsl_sata_t *sata = (fsl_sata_t *)sata_dev_desc[dev].priv;
@@ -835,7 +837,7 @@ ulong sata_read(int dev, u32 blknr, u32 blkcnt, void *buffer)
return rc;
}
-ulong sata_write(int dev, u32 blknr, u32 blkcnt, void *buffer)
+ulong sata_write(int dev, ulong blknr, lbaint_t blkcnt, const void *buffer)
{
u32 rc;
fsl_sata_t *sata = (fsl_sata_t *)sata_dev_desc[dev].priv;
--
1.7.9.5
next prev parent reply other threads:[~2012-09-29 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 20:51 [U-Boot] [PATCH v1 0/9] block: Fix some inconsistencies in block_{read, write} implementors Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 1/9] ata_piix: Fix checkpatch issues Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 2/9] ata_piix: sata_write must take a const void argument Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 3/9] dwc_ahsata: Make sata_write() comply with <part.h> Tom Rini
2012-09-30 9:01 ` stefano babic
2012-09-29 20:51 ` Tom Rini [this message]
2012-09-29 20:51 ` [U-Boot] [PATCH v1 5/9] pata_bfin: Make sata_{read, write}() " Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 6/9] sata_dwc: Make sata_write() use const void, per <part.h> Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 7/9] sil_sata: Make sata_write() comply with <part.h> Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 8/9] ide.h: Make ide_(read|write) match block_dev_desc_t block_(read|write) Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 9/9] sata.h: Make all sata/ata drivers include <sata.h> Tom Rini
2012-10-09 17:14 ` [U-Boot] [PATCH v1 0/9] block: Fix some inconsistencies in block_{read, write} implementors Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348951916-3495-5-git-send-email-trini@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox