[U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc

Stefan Roese
2012-10-05T17:03:32Z

On 10/05/2012 05:22 PM, Tom Rini wrote:

<snip>

>>>> Okay, probably better to add this code now. But shouldn't we
>>>> add this code to the common SPL framework code then? Right
>>>> before calling jump_to_image_linux()?
>>>
>>> Sure, I didn't mean it should go here (it needs to be somewhere
>>> that knows the image start/end, not just the entry point). This
>>> is just the patch that prompted me to ask the question.
>>
>> I see.
>>
>> Tom, whats your input on this? Do you see any problems about
>> putting a flush_cache() into the common SPL framework code? Are any
>> of the ARM platforms currently using this framework already running
>> with d-cache enabled?
>
> On ARM, jump_to_image_linux() calls cleanup_before_linux() to take
> care of flushing, etc. So the PowerPC jump_to_image_linux should take
> care of what it needs to take care of.

Hmmm. Why not move this cleanup_xxx stuff into the common code as well?
Is it really that platform specific? Cache flushing is a common problem.

So basically a "+1" for Scotts comments. But I would suggest to address
this in a follow up patch, to consolidate all this cleanup/cache_flush
stuff. Okay?

Thanks,
Stefan