From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] tegra: usb: move implementation into right directory
Date: Tue, 30 Oct 2012 19:58:58 +0100 [thread overview]
Message-ID: <1351623538.1434.60.camel@tellur> (raw)
In-Reply-To: <509021B9.8060109@wwwdotorg.org>
Am Dienstag, den 30.10.2012, 12:51 -0600 schrieb Stephen Warren:
> On 10/30/2012 12:45 PM, Lucas Stach wrote:
> > Am Dienstag, den 30.10.2012, 12:38 -0600 schrieb Stephen Warren:
> >> On 10/30/2012 03:22 AM, Lucas Stach wrote:
> >>> This moves the Tegra USB implementation into the drivers/usb/host
> >>> directory.
> >>
> >>> diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/drivers/usb/host/ehci-tegra.c
> >>
> >>> + * Copyright (c) 2009-2012 NVIDIA Corporation
> >>> * Copyright (c) 2011 The Chromium OS Authors.
> >>> - * (C) Copyright 2010,2011 NVIDIA Corporation <www.nvidia.com>
> >>
> >> Why does NVIDIA's (c) notice change?
> >>
> > Just because I took most of the licence header from the ehci_tegra.c
> > file, but as the patch shows the the diff modulo the copied part it
> > looks like a change. I choose this one as it actually spans the longer
> > copyright timeframe of the both licence headers. Is this a problem?
> > Should I also include the web address?
>
> Hmm. So this patch merges two files together into one? The diff looks
> like it's creating a new file. If the new content in this patch came
> from some other file, shouldn't the patch also remove it from the old
> file? That would make the (c) header change more obvious.
>
Hm, the rename presentation of this patch seems to cause major
confusion. Yes, this patch merges the Tegra usb implementation into the
pre-existing ehci_tegra.c file, which before this change did not much
more than to call into the Tegra SoC usb implementation. As the Tegra
usb implementation is not really SoC specific, but rather controller
specific this should really move over.
I will send this patch in the usual remove-add presentation for a V2 of
the series, as it even seems to confuse git right now.
Regards,
Lucas
next prev parent reply other threads:[~2012-10-30 18:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 9:22 [U-Boot] [PATCH 1/8] tegra: usb: convert USB_PORTS_MAX to be a define Lucas Stach
2012-10-30 9:22 ` [U-Boot] [PATCH 2/8] tegra: usb: make controller init functions more self contained Lucas Stach
2012-10-30 13:03 ` Simon Glass
2012-10-30 13:16 ` Lucas Stach
2012-10-30 15:35 ` Simon Glass
2012-10-30 9:22 ` [U-Boot] [PATCH 3/8] tegra: usb: fold initial pll setup into board_usb_init Lucas Stach
2012-10-30 13:23 ` Simon Glass
2012-10-30 13:32 ` Lucas Stach
2012-10-30 9:22 ` [U-Boot] [PATCH 4/8] tegra: usb: remove unneeded function parameter Lucas Stach
2012-10-30 13:18 ` Simon Glass
2012-10-30 9:22 ` [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port Lucas Stach
2012-10-30 10:59 ` Marek Vasut
2012-10-30 12:12 ` Lucas Stach
2012-10-30 12:33 ` Marek Vasut
2012-10-30 12:44 ` Lucas Stach
2012-10-30 18:34 ` Stephen Warren
2012-10-30 13:27 ` Simon Glass
2012-10-30 13:37 ` Lucas Stach
2012-10-30 13:48 ` Simon Glass
2012-10-30 13:54 ` Lucas Stach
2012-10-30 14:03 ` Simon Glass
2012-10-30 9:22 ` [U-Boot] [PATCH 6/8] tegra: usb: various small cleanups Lucas Stach
2012-10-30 13:31 ` Simon Glass
2012-10-30 9:22 ` [U-Boot] [PATCH 7/8] tegra: usb: move implementation into right directory Lucas Stach
2012-10-30 13:33 ` Simon Glass
2012-10-30 13:38 ` Lucas Stach
2012-10-30 13:53 ` Simon Glass
2012-10-30 14:03 ` Lucas Stach
2012-10-30 16:11 ` Tom Warren
2012-10-30 16:18 ` Simon Glass
2012-10-30 18:38 ` Stephen Warren
2012-10-30 18:45 ` Lucas Stach
2012-10-30 18:51 ` Stephen Warren
2012-10-30 18:58 ` Lucas Stach [this message]
2012-10-30 9:22 ` [U-Boot] [PATCH 8/8] tegra: usb: move [start|stop]_port into ehci_hcd_[init|stop] Lucas Stach
2012-10-30 13:39 ` Simon Glass
2012-10-30 13:09 ` [U-Boot] [PATCH 1/8] tegra: usb: convert USB_PORTS_MAX to be a define Simon Glass
2012-10-30 13:11 ` Marek Vasut
2012-10-30 13:40 ` Simon Glass
2012-11-02 20:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351623538.1434.60.camel@tellur \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox