* [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root
@ 2024-11-20 10:19 Heiko Stuebner
2024-11-20 11:13 ` Quentin Schulz
2024-11-21 2:04 ` Kever Yang
0 siblings, 2 replies; 4+ messages in thread
From: Heiko Stuebner @ 2024-11-20 10:19 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang; +Cc: heiko, u-boot
The mask for aclk_vop_root is 3-bit wide, not 2-bit wide according
to the TRM, so set the mask accordingly.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/include/asm/arch-rockchip/cru_rk3588.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
index dad484813fa..afce8a44af3 100644
--- a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
+++ b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
@@ -346,7 +346,7 @@ enum {
ACLK_VOP_LOW_ROOT_SEL_100M,
ACLK_VOP_LOW_ROOT_SEL_24M,
ACLK_VOP_ROOT_SEL_SHIFT = 5,
- ACLK_VOP_ROOT_SEL_MASK = 3 << ACLK_VOP_ROOT_SEL_SHIFT,
+ ACLK_VOP_ROOT_SEL_MASK = 7 << ACLK_VOP_ROOT_SEL_SHIFT,
ACLK_VOP_ROOT_SEL_GPLL = 0,
ACLK_VOP_ROOT_SEL_CPLL,
ACLK_VOP_ROOT_SEL_AUPLL,
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root
2024-11-20 10:19 [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root Heiko Stuebner
@ 2024-11-20 11:13 ` Quentin Schulz
2024-11-20 11:26 ` Heiko Stuebner
2024-11-21 2:04 ` Kever Yang
1 sibling, 1 reply; 4+ messages in thread
From: Quentin Schulz @ 2024-11-20 11:13 UTC (permalink / raw)
To: Heiko Stuebner, sjg, philipp.tomsich, kever.yang; +Cc: u-boot
Hi Heiko,
On 11/20/24 11:19 AM, Heiko Stuebner wrote:
> The mask for aclk_vop_root is 3-bit wide, not 2-bit wide according
> to the TRM, so set the mask accordingly.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Was this a drive-by bug fix or did you actually experience some bug?
Basically trying to figure out if we should push for this being merged
for 2025.01 or if it's fine if it misses it?
Thanks!
Quentin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root
2024-11-20 11:13 ` Quentin Schulz
@ 2024-11-20 11:26 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2024-11-20 11:26 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang, Quentin Schulz; +Cc: u-boot
Am Mittwoch, 20. November 2024, 12:13:32 CET schrieb Quentin Schulz:
> On 11/20/24 11:19 AM, Heiko Stuebner wrote:
> > The mask for aclk_vop_root is 3-bit wide, not 2-bit wide according
> > to the TRM, so set the mask accordingly.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Was this a drive-by bug fix or did you actually experience some bug?
> Basically trying to figure out if we should push for this being merged
> for 2025.01 or if it's fine if it misses it?
on my side, it was a "drive-by" thing and I actually don't remember
anymore, what made me look at that. So I don't experience any
bug on my side.
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root
2024-11-20 10:19 [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root Heiko Stuebner
2024-11-20 11:13 ` Quentin Schulz
@ 2024-11-21 2:04 ` Kever Yang
1 sibling, 0 replies; 4+ messages in thread
From: Kever Yang @ 2024-11-21 2:04 UTC (permalink / raw)
To: Heiko Stuebner, sjg, philipp.tomsich; +Cc: u-boot
On 2024/11/20 18:19, Heiko Stuebner wrote:
> The mask for aclk_vop_root is 3-bit wide, not 2-bit wide according
> to the TRM, so set the mask accordingly.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
There is a same change/fix to vendor U-Boot at 2022.
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/include/asm/arch-rockchip/cru_rk3588.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> index dad484813fa..afce8a44af3 100644
> --- a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> +++ b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
> @@ -346,7 +346,7 @@ enum {
> ACLK_VOP_LOW_ROOT_SEL_100M,
> ACLK_VOP_LOW_ROOT_SEL_24M,
> ACLK_VOP_ROOT_SEL_SHIFT = 5,
> - ACLK_VOP_ROOT_SEL_MASK = 3 << ACLK_VOP_ROOT_SEL_SHIFT,
> + ACLK_VOP_ROOT_SEL_MASK = 7 << ACLK_VOP_ROOT_SEL_SHIFT,
> ACLK_VOP_ROOT_SEL_GPLL = 0,
> ACLK_VOP_ROOT_SEL_CPLL,
> ACLK_VOP_ROOT_SEL_AUPLL,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-21 2:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-20 10:19 [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root Heiko Stuebner
2024-11-20 11:13 ` Quentin Schulz
2024-11-20 11:26 ` Heiko Stuebner
2024-11-21 2:04 ` Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox