From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 1 Dec 2016 09:26:32 +0100 Subject: [U-Boot] [PATCH 02/17] arm: mvebu: Add gpio support In-Reply-To: References: Message-ID: <13535b7b-2b63-ae43-5e4f-ceea7c0eb6be@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mario, sorry for the late review. A few comments now to the patch series... On 23.11.2016 16:12, Mario Six wrote: > From: Dirk Eibach > > Add driver interface functions for the GPIO controller on the mvebu > architecture (based on kirkwood). > > Signed-off-by: Dirk Eibach > --- > arch/arm/mach-mvebu/include/mach/gpio.h | 41 +++++++++++++++++++++++++++++++-- > 1 file changed, 39 insertions(+), 2 deletions(-) This is no "real" GPIO driver but only adds to the old GPIO infrastructure. I've added a DM based GPIO driver for MVEBU quite a while ago: drivers/gpio/mvebu_gpio.c Could you please try to use this driver instead? If something is missing in this driver then please extend this DM driver. Thanks, Stefan