[U-Boot] [PATCH v2 5/7] Tegra30: Cardhu: Add DT files

Simon Glass
2012-12-04T00:49:24Z

Hi Stephen,

On Mon, Dec 3, 2012 at 4:40 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 12/03/2012 04:45 PM, Tom Warren wrote:
>> These are stripped down for bringup, They'll be filled out later
>> to match-up with the kernel DT contents, and/or as devices are
>> brought up (mmc, usb, spi, etc.).
>>
>> Signed-off-by: Tom Warren <twarren@nvidia.com>
>
>> diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi
>
>> +/ {
>> + model = "NVIDIA Tegra30";
>
> We don't really need a model property here, but it's not a big deal.

We do actually use it in U-Boot (in ARM patches on the mailing list).

>
>> diff --git a/board/nvidia/dts/tegra30-cardhu.dts b/board/nvidia/dts/tegra30-cardhu.dts
>
>> +/memreserve/ 0x1c000000 0x04000000;
>
> /memreserve/ isn't correct for U-Boot; no memory should be reserved.

But don't we want to use the same fdt for U-Boot as the kernel?

>
>> +/ {
>> + model = "NVIDIA Cardhu";
>> + compatible = "nvidia,cardhu", "nvidia,tegra30";
>> +
>> + memory {
>> + device_type = "memory";
>> + reg = <0x80000000 0xc0000000>;
>
> That last number should be 0x40000000; it's a size not an end-of-region
> value.
>
> Note that once things get more advanced, we'll need to split this up
> into tegra30-cardhu.dtsi, tegra30-cardhu-a02.dts,
> tegra30-cardhu-a04.dts, but we can do that later.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Simon