[U-Boot] [PATCH 10/10] tools: Add support for Dove to kwboot

[Daniel Stodden <daniel.stodden@googlemail.com>]

On Thu, 2012-12-06 at 11:59 +0100, Sebastian Hesselbarth wrote:
> On 12/05/2012 11:15 PM, Daniel Stodden wrote:
> > On Sun, 2012-12-02 at 20:15 +0100, Luka Perkov wrote:
> >> On Sun, Dec 02, 2012 at 03:36:22PM +0100, Sebastian Hesselbarth wrote:
> >>> On Dove kwboot can also be used to boot an u-boot image into RAM.
> >>> In contrast to Kirkwood, Dove does not support the UART boot mode
> >>> sequence but requires the UART boot mode to be selected through
> >>> strap pins. The SolidRun CuBox has a push button to allow uart
> >>> boot mode but fails on the boot sequence sent by kwboot.
> > ...
> > since the protocol remains the same, and just doesn't take a boot
> > message while polling, better to keep the bootmsg_call() intact and just
> > make the option parsing flip the message type?
> >
> > The original BootROM had a couple more message, the tool just no
> > immediate use for that. Eventual options to change message type wasn't
> > unanticipated. Ok, no message at all was.
> >
> > Sketchy patch attached for your consideration. Beware, I can't test it
> > right now.
> 
> Hi Daniel,
> 
> I tried your patch and except that you forgot to add 'n' to the getopt
> call, it works as expected.

Thanks, mission accomplished :)

> > Also, while I've got nothing against adding a flag for that, I'm partly
> > wondering whether this took a patch at all -- what's the target behavior
> > if you keep shooting it with the original boot message?
> >
> > I would assume it would keep responding with NAKs. But doesn't?
> 
> I tried original kwboot and it failed, then I checked the DS for the boot
> sequence and finally found out, that Dove doesn't support the "force into
> UART boot mode" sequence. But your are right, if I reboot Dove into UART
> boot mode it makes no difference if you send the sequence or not. It works
> on both kwboot modes.
> 
> It just doesn't work if you are doing a normal boot of Dove, as it ignores
> the sequence sent.
> 
> So finally, we have three options:
> - leave kwboot as is and hope the user will know about Dove's inability to
> use the boot sequence
> - add a note to usage() and kwboot that Dove doen't like the sequence
> - add an option to kwboot as you are proposing

Okay, here's a deal.

We've got a bit of a backward compatibility problem anyway. Dave Purdy
was so kind to write up a summary of popular devices known working and
not working. That's mainly a matter of firmware revisions. [1]

 - Let's add a message selector, -m <foo> or so.

   Kirkwood specs list two types, let's make those -mdebug and -muart.

   If we add -m debug, maybe that even results in someone on the web
   being ultimately able to explain wth debug mode does :)

   Default is -m uart, that's what's going on right now.

 - We add -mnone for pin-selected uart boot mode.

 - Maybe a slightly less specific printv message.

 - But most importantly, we add a COMPATIBILITY section to the manpage,
   and explain the difference between core revisions there.

We could drop the none case. But then again, if the target isn't reset
yet, then not scribbling into getties and stuff where it's avoidable
might be preferred by those who can. So why not.

Could you try to read us the boot firmware revision you're running? It's
described under the link below. Not sure if it works on your platform
though.

Daniel

[1] http://forum.doozan.com/read.php?3,7852