From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Tue, 11 Dec 2012 11:10:05 -0600
Subject: [U-Boot] [PATCH] m28evk/mx28evk: fix nand_update_full
In-Reply-To: <20121211095037.718448a3@eb-e6520> (from eric@eukrea.com on Tue
	Dec 11 02:50:37 2012)
References: <1355157719-10409-1-git-send-email-eric@eukrea.com>
	<1355180363.5334.16@snotra> <20121211095037.718448a3@eb-e6520>
Message-ID: <1355245805.13481.0@snotra>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/11/2012 02:50:37 AM, Eric B?nard wrote:
> Hi Scott,
> 
> Le Mon, 10 Dec 2012 16:59:23 -0600,
> Scott Wood <scottwood@freescale.com> a ?crit :
> 
> > On 12/10/2012 10:41:59 AM, Eric B?nard wrote:
> > > - commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the
> > > behaviour
> > > of nand write.raw which now takes a pagecount as a parameter and  
> no
> > > more
> > > the size to be written so update the default environment of these
> > > boards
> > > to fix the problem.
> >
> > It never really took the size to be written -- the size was  
> implicitly
> > one page before.  It looks like there may have been a bug in the old
> > code, where common code expected a size to be there anyway, even  
> though
> > it was ignored other than for error checking.
> >
> true, before the size was forced to one page :
> rwsize = nand->writesize + nand->oobsize;
> now it's rwsize = pagecount * (nand->writesize + nand->oobsize);
> so the size parameter in this script was ignored and now leads to a
> wrong rwsize calculation.
> 
> Do you want me to rephrase the commit log or will you take it as is ?

Please reword it.

-Scott