From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Thu, 13 Dec 2012 15:59:01 -0600
Subject: [U-Boot] [PATCH v3] imls: Add support to list images in NAND
	device
In-Reply-To: <770877195ea30a60d80ed240962f1386d5451926.1355395028.git.vipin.kumar@st.com>
	(from vipin.kumar@st.com on Thu Dec 13 04:38:18 2012)
Message-ID: <1355435941.14046.9@snotra>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/13/2012 04:38:18 AM, Vipin Kumar wrote:
> +		for (off = 0; off < nand->size; off += nand->erasesize)  
> {
> +			const image_header_t *header;
> +			int ret;
> +
> +			if (nand_block_isbad(nand, off))
> +				continue;
> +
> +			len = sizeof(buffer);
> +
> +			ret = nand_read(nand, off, &len, (u8 *)buffer);
> +			if (ret < 0 && ret != -EUCLEAN)
> +				continue;

Might want to make some noise if you get an uncorrectable error.

> +
> +			switch (genimg_get_format(buffer)) {
> +			case IMAGE_FORMAT_LEGACY:
> +				header = (const image_header_t *)buffer;
> +				len = image_get_image_size(header);
> +
> +				ret = nand_imls_legacyimage(nand,  
> nand_dev,
> +						off, len);
> +				if (ret < 0 && ret != -ENOMEM)
> +					return ret;
> +				break;
> +#if defined(CONFIG_FIT)
> +			case IMAGE_FORMAT_FIT:
> +				len = fit_get_size(buffer);
> +				ret = nand_imls_fitimage(nand, nand_dev,
> +						off, len);
> +				if (ret < 0 && ret != -ENOMEM)
> +					return ret;
> +				break;
> +#endif
> +			}

Do you really mean to return from the main imls function just because  
one image has an error?  By "use return" I meant return from the  
subfunction.

-Scott