From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 14 Dec 2012 12:59:36 -0600 Subject: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device In-Reply-To: <50CAF00E.90403@st.com> (from vipin.kumar@st.com on Fri Dec 14 03:23:26 2012) References: <1355435572.14046.8@snotra> <50CAF00E.90403@st.com> Message-ID: <1355511576.4740.5@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/14/2012 03:23:26 AM, Vipin Kumar wrote: > On 12/14/2012 3:22 AM, Scott Wood wrote: >> On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: >>>>> + imgdata = malloc(read_size); >>>>> + if (!imgdata) { >>>>> + printf("Not able to list all >>>>> images " \ >>>>> + "(Low memory)\n"); >>>> >>>> Don't line-wrap error strings. >>>> >>> >>> 80 column ? >> >> Error strings are an exception for the sake of greppability. From >> Linux's Documentation/CodingStyle: >> >> Statements longer than 80 columns will be broken into sensible >> chunks, unless >> exceeding 80 columns significantly increases readability and does >> not hide >> information. Descendants are always substantially shorter than >> the >> parent and >> are placed substantially to the right. The same applies to >> function >> headers >> with a long argument list. However, never break user-visible >> strings >> such as >> printk messages, because that breaks the ability to grep for >> them. >> > > Yes, thanks for reminding. The error strings are more readable > already in v3. Please take a look No, you're still breaking up strings (and you also have a totally unnecessary backslash). If it's on one line in the output, it should be on one line in the source. -Scott