From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 17 Dec 2012 12:53:27 -0600 Subject: [U-Boot] [PATCH] env: don't generate callback list entries for SPL In-Reply-To: <20121217145259.GB6167@bill-the-cat> (from trini@ti.com on Mon Dec 17 08:52:59 2012) Message-ID: <1355770407.18495.2@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/17/2012 08:52:59 AM, Tom Rini wrote: > On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: > > > SPL doesn't use the environment. These list entries prevent the > > functions from being garbage-collected, even though nothing will > look at > > the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to > > break due to size limitations. > > SPL with networking support uses the environment, so you need to toss > CONFIG_SPL_NET_SUPPORT into the test. That said, it's not an > interactive environment and this might push that area over the size > limit too (in the USB case, which is already pretty tight). OK, I saw "env_*" stuff in the "ifndef CONFIG_SPL_BUILD" section, but later some of it shows up in "ifdef CONFIG_SPL_BUILD" as well. So, do you want a v2, or is it OK because it's not interactive? In the latter case should env_callback.o be removed from the SPL build? Also, env_nvedit.o, env_common.o, and env_flash.o are included for SPL regardless of CONFIG_SPL_NET_SUPPORT. In fact it looks like env_nvedit.o will be included twice if CONFIG_SPL_NET_SUPPORT is enabled. :-P -Scott