[U-Boot] [RFC PATCH v2 0/5] Initial IPv6 support

Chris Packham
2013-01-20T09:24:58Z

On 01/18/2013 11:23 PM, Wolfgang Denk wrote:
> Dear Chris,
>
> In message <1358472932-32083-1-git-send-email-judge.packham@gmail.com> you wrote:
>>
>> This series so far covers the introduction of a IP6addr_t and
>> printing/parsing of addresses. I have a patch for testing these basic
>> things which I haven't included in this series yet. Is there a unittest
>> facility for u-boot I should be using?
>
> We use the DUTS ([1], [2]) for all kind of test cases (but note that
> I don't claim it's easy to get started with it).
>
> [1] http://www.denx.de/wiki/DUTS/DUTSDocs
> [2] http://git.denx.de/?p=duts.git
>
>> A few open questions
>>
>> 1) Presumably the majority of the actual V6 code would be included by a
>> config option (CONFIG_IPV6). How far should I take that? Should the
>> vsprintf code be conditional?
>
> Yes, please.
>
>> 2) Our current out of tree code parallels net.c and net.h. Should I
>> continue this for the final version or integrate it into net.[ch].
>
> This depends - if such integration can be done nicely, i. e. without
> too many new #ifdef's, then yes, please.
>
>> 3) rxhand_f currently takes an IPaddr_t. I haven't looked at the usage
>> of this yet but to support V6 this may need to be a new union or a void
>> *.
>
> What exactly is the question here?

The POSIX solution for this is to use sockaddr which encompasses both v4
and v6 addresses (as well as other socket types). Do we want to add a
wrapper type or just work with void *?

I also need to look at things that implement a rxhand_f just to see what
they do with the IPaddr_t.

>
> Best regards,
>
> Wolfgang Denk
>