public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: pinmux: fix FUNCMUX_NDFLASH_KBC_8_BIT
Date: Tue, 22 Jan 2013 01:20:41 +0100	[thread overview]
Message-ID: <1358814041-5117-1-git-send-email-dev@lynxeye.de> (raw)

Even the 8bit case needs KBCB configured, as pin D7 is located in this
pingroup. Also pingroup ATC seems to come out of reset with config set
to NAND, so we need to explictly configure some other function to this
group in order to avoid clashing settings.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/cpu/tegra20-common/funcmux.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/cpu/tegra20-common/funcmux.c b/arch/arm/cpu/tegra20-common/funcmux.c
index a1c55a6..30fdf1c 100644
--- a/arch/arm/cpu/tegra20-common/funcmux.c
+++ b/arch/arm/cpu/tegra20-common/funcmux.c
@@ -266,17 +266,25 @@ int funcmux_select(enum periph_id id, int config)
 			break;
 		case FUNCMUX_NDFLASH_KBC_8_BIT:
 			pinmux_set_func(PINGRP_KBCA, PMUX_FUNC_NAND);
+			pinmux_set_func(PINGRP_KBCB, PMUX_FUNC_NAND);
 			pinmux_set_func(PINGRP_KBCC, PMUX_FUNC_NAND);
 			pinmux_set_func(PINGRP_KBCD, PMUX_FUNC_NAND);
 			pinmux_set_func(PINGRP_KBCE, PMUX_FUNC_NAND);
 			pinmux_set_func(PINGRP_KBCF, PMUX_FUNC_NAND);
 
 			pinmux_tristate_disable(PINGRP_KBCA);
+			pinmux_tristate_disable(PINGRP_KBCB);
 			pinmux_tristate_disable(PINGRP_KBCC);
 			pinmux_tristate_disable(PINGRP_KBCD);
 			pinmux_tristate_disable(PINGRP_KBCE);
 			pinmux_tristate_disable(PINGRP_KBCF);
 
+			/*
+			 * configure pingroup ATC to something unrelated to
+			 * avoid ATC overriding KBC
+			 */
+			pinmux_set_func(PINGRP_ATC, PMUX_FUNC_GMI);
+
 			bad_config = 0;
 			break;
 		}
-- 
1.8.0.2

             reply	other threads:[~2013-01-22  0:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22  0:20 Lucas Stach [this message]
2013-01-22 16:24 ` [U-Boot] [PATCH] tegra: pinmux: fix FUNCMUX_NDFLASH_KBC_8_BIT Stephen Warren
2013-01-22 22:27   ` Lucas Stach
2013-01-23  1:55     ` Allen Martin
  -- strict thread matches above, loose matches on Subject: below --
2015-03-24 12:29 Marcel Ziswiler
2015-03-24 15:21 ` Stephen Warren
2015-03-25  7:42   ` Marcel Ziswiler
2015-03-25 17:46   ` Marcel Ziswiler
2015-03-25 18:08     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358814041-5117-1-git-send-email-dev@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox