From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/7] tegra: usb: various small cleanups
Date: Fri, 25 Jan 2013 15:41:09 +0100 [thread overview]
Message-ID: <1359124871-4434-6-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1359124871-4434-1-git-send-email-dev@lynxeye.de>
Remove unneeded headers, function prototype and stale comment, that
doesn't match the actual codebase anymore.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
arch/arm/cpu/armv7/tegra20/usb.c | 13 +------------
arch/arm/include/asm/arch-tegra20/usb.h | 3 ---
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/arch/arm/cpu/armv7/tegra20/usb.c
index e4165e0..3fdd5df 100644
--- a/arch/arm/cpu/armv7/tegra20/usb.c
+++ b/arch/arm/cpu/armv7/tegra20/usb.c
@@ -25,21 +25,15 @@
#include <asm/io.h>
#include <asm-generic/gpio.h>
#include <asm/arch/clock.h>
-#include <asm/arch/gpio.h>
-#include <asm/arch/pinmux.h>
-#include <asm/arch/tegra.h>
#include <asm/arch/usb.h>
#include <usb/ulpi.h>
-#include <asm/arch-tegra/clk_rst.h>
-#include <asm/arch-tegra/sys_proto.h>
-#include <asm/arch-tegra/uart.h>
#include <libfdt.h>
#include <fdtdec.h>
#ifdef CONFIG_USB_ULPI
#ifndef CONFIG_USB_ULPI_VIEWPORT
#error "To use CONFIG_USB_ULPI on Tegra Boards you have to also \
- define CONFIG_USB_ULPI_VIEWPORT"
+ define CONFIG_USB_ULPI_VIEWPORT"
#endif
#endif
@@ -191,11 +185,6 @@ void usbf_reset_controller(struct fdt_usb *config, struct usb_ctlr *usbctlr)
/* Enable the UTMIP PHY */
if (config->utmi)
setbits_le32(&usbctlr->susp_ctrl, UTMIP_PHY_ENB);
-
- /*
- * TODO: where do we take the USB1 out of reset? The old code would
- * take USB3 out of reset, but not USB1. This code doesn't do either.
- */
}
/* set up the UTMI USB controller with the parameters provided */
diff --git a/arch/arm/include/asm/arch-tegra20/usb.h b/arch/arm/include/asm/arch-tegra20/usb.h
index fdbd127..b18c850 100644
--- a/arch/arm/include/asm/arch-tegra20/usb.h
+++ b/arch/arm/include/asm/arch-tegra20/usb.h
@@ -243,9 +243,6 @@ struct usb_ctlr {
#define VBUS_VLD_STS (1 << 26)
-/* Change the USB host port into host mode */
-void usb_set_host_mode(void);
-
/* Setup USB on the board */
int board_usb_init(const void *blob);
--
1.8.0.2
next prev parent reply other threads:[~2013-01-25 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 14:41 [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place Lucas Stach
2013-01-25 14:41 ` [U-Boot] [PATCH v2 1/7] tegra: usb: set USB_PORTS_MAX to correct value Lucas Stach
2013-01-25 21:22 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 2/7] tegra: usb: make controller init functions more self contained Lucas Stach
2013-01-27 16:31 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 3/7] tegra: usb: remove unneeded function parameter Lucas Stach
2013-01-25 14:41 ` [U-Boot] [PATCH v2 4/7] tegra: usb: move controller init into start_port Lucas Stach
2013-01-27 16:33 ` Simon Glass
2013-01-25 14:41 ` Lucas Stach [this message]
2013-01-25 21:23 ` [U-Boot] [PATCH v2 5/7] tegra: usb: various small cleanups Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 6/7] tegra: usb: move implementation into right directory Lucas Stach
2013-01-25 21:25 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 7/7] tegra: usb: move [start|stop]_port into ehci_hcd_[init|stop] Lucas Stach
2013-01-27 16:33 ` Simon Glass
2013-01-25 16:07 ` [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place Tom Warren
2013-01-25 16:19 ` Lucas Stach
2013-01-26 3:26 ` Marek Vasut
2013-01-27 23:33 ` Stephen Warren
2013-01-27 23:48 ` Marek Vasut
2013-01-28 16:10 ` Stephen Warren
2013-01-28 16:29 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359124871-4434-6-git-send-email-dev@lynxeye.de \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox