From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Date: Fri, 25 Jan 2013 17:19:16 +0100 [thread overview]
Message-ID: <1359130756.1540.77.camel@tellur> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37A4D1D2E0@HQMAIL04.nvidia.com>
Hello Tom,
Am Freitag, den 25.01.2013, 08:07 -0800 schrieb Tom Warren:
> I tried to apply this to u-boot-tegra/next and it needed some massaging to get it to apply cleanly. Minor stuff, but you'll need to rebase it on top of current u-boot-tegra/next (I just pushed a new version with my 'Move common clock code' patch and Allen's fix for the DTS sort patch. Sorry, but the Tegra repo is going to be fairly dynamic for the next few weeks.
>
Ok, I'll wait for some comments on the actual code, then repost a
rebased version.
> Also, when I did get it applied and tried to ./MAKEALL -s tegra20 -s tegra30, I got the following warning on all T20 builds:
>
> ehci-tegra.c: In function 'ehci_hcd_init':
> ehci-tegra.c:565: warning: assignment makes pointer from integer without a cast
> ehci-tegra.c:566: warning: assignment makes pointer from integer without a cast
>
Ah damn, forgot to squash the fix in the last patch.
> Also, it appears that arch-tegra20/usb.h is still hanging around (in my edited patch series, at any rate). Shouldn't the moved arch-tegra/usb.h be used exclusively? Removing arch-tegra20/usb.h causes fatal errors in nvidia/common/board.c. If it does need to exist, then it needs to live in arch-tegra30, also, so it'll be available when T30 gets USB turned on.
I don't see why this is happening. The shortlog points at git picking up
the rename at the in the wrong dir, I'll look into this when reposting.
But the change to nvidia/common/board.c to use the new include dir is
definitely included in patch 6.
Regards,
Lucas
next prev parent reply other threads:[~2013-01-25 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 14:41 [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place Lucas Stach
2013-01-25 14:41 ` [U-Boot] [PATCH v2 1/7] tegra: usb: set USB_PORTS_MAX to correct value Lucas Stach
2013-01-25 21:22 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 2/7] tegra: usb: make controller init functions more self contained Lucas Stach
2013-01-27 16:31 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 3/7] tegra: usb: remove unneeded function parameter Lucas Stach
2013-01-25 14:41 ` [U-Boot] [PATCH v2 4/7] tegra: usb: move controller init into start_port Lucas Stach
2013-01-27 16:33 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 5/7] tegra: usb: various small cleanups Lucas Stach
2013-01-25 21:23 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 6/7] tegra: usb: move implementation into right directory Lucas Stach
2013-01-25 21:25 ` Simon Glass
2013-01-25 14:41 ` [U-Boot] [PATCH v2 7/7] tegra: usb: move [start|stop]_port into ehci_hcd_[init|stop] Lucas Stach
2013-01-27 16:33 ` Simon Glass
2013-01-25 16:07 ` [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place Tom Warren
2013-01-25 16:19 ` Lucas Stach [this message]
2013-01-26 3:26 ` Marek Vasut
2013-01-27 23:33 ` Stephen Warren
2013-01-27 23:48 ` Marek Vasut
2013-01-28 16:10 ` Stephen Warren
2013-01-28 16:29 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359130756.1540.77.camel@tellur \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox