From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] corenet: Disable video on P2020DS
Date: Fri, 25 Jan 2013 13:35:08 -0600 [thread overview]
Message-ID: <1359142508.32493.17@snotra> (raw)
In-Reply-To: <1359141933.32493.15@snotra> (from scottwood@freescale.com on Fri Jan 25 13:25:33 2013)
On 01/25/2013 01:25:33 PM, Scott Wood wrote:
> On 01/25/2013 12:50:59 PM, Tom Rini wrote:
>> On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
>>
>> > The P2020DS build had grown too large, and video support isn't
>> enabled
>> > in almost any other Freescale board. Disabling it allows us to keep
>> > building, and provides options for reenabling it later.
>> >
>> > Signed-off-by: Andy Fleming <afleming@freescale.com>
>>
>> Now we may start having dead code around, yes? Can you perhaps get
>> away
>> with making this be disable video or something else and add a
>> P2020DS_video boards.cfg entry or similar? Thanks!
>
> There are already 5 P2020DS targets, and there *should* be 8 (why is
> there no 36BIT version of DDR2, SDCARD, or SPIFLASH?).
I take that back -- there should be 16, as DDR2 seems to be orthogonal
as well. So adding VIDEO on/off for all configs would bring it up to
32 if we fixed the rest.
I suppose you could just have one video config for compilation
coverage, but it seems awkward, and what is it really testing? It's
not the only board to enable BIOSEMU, ATI framebuffer, etc. You'd just
be testing that it works with p2020ds, but for integration testing one
config working might not say anything about another.
-Scott
next prev parent reply other threads:[~2013-01-25 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 16:38 [U-Boot] [PATCH] corenet: Disable video on P2020DS Andy Fleming
2013-01-25 18:50 ` Tom Rini
2013-01-25 19:25 ` Scott Wood
2013-01-25 19:35 ` Scott Wood [this message]
2013-01-25 19:35 ` Tom Rini
2013-01-25 20:43 ` Fleming Andy-AFLEMING
2013-01-25 20:48 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359142508.32493.17@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox