public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] CONFIG_DELAY_ENVIRONMENT usage
Date: Wed, 30 Jan 2013 07:08:39 +0100	[thread overview]
Message-ID: <1359526119.20176.1.camel@tellur> (raw)
In-Reply-To: <20130130030549.GA19514@badger>

Hi Allen,

Am Dienstag, den 29.01.2013, 19:05 -0800 schrieb Allen Martin:

> The problem I'm seeing is that this regressed environment loading on
> all boards that use fdt, because none of them have
> /config/load-environment defined.  If I read the commit message
> correctly, I think the actual intention is:
> 
> static int should_load_env(void)
> {
> #ifdef CONFIG_DELAY_ENVIRONMENT
> #ifdef CONFIG_OF_CONTROL
>         return fdtdec_get_config_int(gd->fdt_blob, "load-environment",
> 	0);
> #else
>         return 0;
> #endif
> #else
>         return 1;
> #endif
> }
> 
There is already a patch for that on the mailing list. See
http://www.mail-archive.com/u-boot at lists.denx.de/msg103841.html

We agreed that just swapping around the default value for the FDT case
is the right thing to do.

Regards,
Lucas

  reply	other threads:[~2013-01-30  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30  3:05 [U-Boot] CONFIG_DELAY_ENVIRONMENT usage Allen Martin
2013-01-30  6:08 ` Lucas Stach [this message]
2013-01-30 17:37   ` Allen Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359526119.20176.1.camel@tellur \
    --to=dev@lynxeye.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox