From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Date: Wed, 30 Jan 2013 07:08:39 +0100 Subject: [U-Boot] CONFIG_DELAY_ENVIRONMENT usage In-Reply-To: <20130130030549.GA19514@badger> References: <20130130030549.GA19514@badger> Message-ID: <1359526119.20176.1.camel@tellur> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Allen, Am Dienstag, den 29.01.2013, 19:05 -0800 schrieb Allen Martin: > The problem I'm seeing is that this regressed environment loading on > all boards that use fdt, because none of them have > /config/load-environment defined. If I read the commit message > correctly, I think the actual intention is: > > static int should_load_env(void) > { > #ifdef CONFIG_DELAY_ENVIRONMENT > #ifdef CONFIG_OF_CONTROL > return fdtdec_get_config_int(gd->fdt_blob, "load-environment", > 0); > #else > return 0; > #endif > #else > return 1; > #endif > } > There is already a patch for that on the mailing list. See http://www.mail-archive.com/u-boot at lists.denx.de/msg103841.html We agreed that just swapping around the default value for the FDT case is the right thing to do. Regards, Lucas