[U-Boot] [PATCH 07/11] blackfin: bf609: add board and headers files to support bf609

Wolfgang Denk
2013-02-17T20:13:57Z

Dear Sonic Zhang,

In message <CAJxxZ0MbkmPgGjFrQR3Uq0M=V-67gBryF1oTQd6_ayv8pZh2Dw@mail.gmail.com> you wrote:
> On Thu, Feb 7, 2013 at 6:26 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Sonic Zhang,
> >
> > In message <1360223258-6945-8-git-send-email-sonic.adi@gmail.com> you wrote:
> >> From: Sonic Zhang <sonic.zhang@analog.com>
> >>
> >> Board and config header files for bf609-ezkit support.
> >
> > Checkpatch errors, please fix.
> >
> >
> >> +#define ADI_CMDS_NETWORK 1
> >> +#define CONFIG_NETCONSOLE 1
> >> +#define CONFIG_NET_MULTI 1
> >
> > Please do not define values for variables that don't actually have
> > one. Please fix globally.
>
> The values of these 3 variables are used in
> include/configs/bfin_adi_common.h. They should be defined values,
> otherwise the compilation fails.

This is a bug in include/configs/bfin_adi_common.h then, which needs
to be fixed there.

It is wrong to use #if on these defines.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How much net work could a network work, if a network could net work?