[U-Boot] [PATCH 02/11] Blackfin: bf60x: Port blackfin core architecture code to boot on bf60x.

Sonic Zhang
2013-02-08T04:31:48Z

On Thu, Feb 7, 2013 at 6:21 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Sonic Zhang,
>
> In message <1360223258-6945-3-git-send-email-sonic.adi@gmail.com> you wrote:
>> From: Sonic Zhang <sonic.zhang@analog.com>
>>
>> Set up clocks, DDR controller, Nor flash controller, reboot,
>> serial port. Add new SPI boot modes.
>
> Checkpatch issues, please fix.
>

OK

>
>> +#ifndef __ADSPBF60x__
>> +#include <asm/mach-common/bits/pll.h>
>> +#else
>> +#include <asm/mach-common/bits/cgu.h>
>> +#endif
>
> General question: you add a _lot_ of new #ifdef's all over the place.
>
> Also, I think I see lots of duplicated (or very similar) code.
>
> Can this not be avoided?

I tried to avoid #ifdef's. But, BF60x differs a lot in on-chip
peripherals from those in BF5xx. I will try to clean up the #ifdef's
on my best.

>
>
>> if (BFIN_DEBUG_EARLY_SERIAL) {
>> - int ucen = bfin_read16(&pUART->gctl) & UCEN;
>> + int enabled = serial_early_enabled(uart_base);
>> serial_early_init(uart_base);
>
> Please spearate declarations and code by a blankline. Please fix
> globally (at least where you touch the code anyway).

OK.

Thanks,

Sonic