[U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

Wolfgang Denk
2013-02-07T10:17:42Z

Dear Sonic Zhang,

In message <1360223258-6945-9-git-send-email-sonic.adi@gmail.com> you wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Add rsi/sdh support for bf60x.

Checkpatch errors. Please fix.

> @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data)
...
> - int ret = 0;
...
> - return ret;
> + return 0;

If this function can always only return 0, then please make it void.

Please fix globally.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is dangerous to be right on a subject on which the established
authorities are wrong. -- Voltaire