[U-Boot] [PATCH 09/11] Blackfin: spi: add bf6xx spi driver

Wolfgang Denk
2013-02-17T20:12:33Z

Dear Sonic Zhang,

In message <CAJxxZ0OLH71+HCkGiR1CdFApdqqY4fKoa3e_mjvhozUSa=sEzg@mail.gmail.com> you wrote:
>
> > Checkpatch issues, please fix.
> >
> Could the checkpatch warning "line over 80 characters" in head file
> Macro definition be ignored? I think put the explanation and the
> definition on the same line is more clean than to chopping to 80.

No. It is more or less a mandatory requirement.

> #define SPI_CTL_FIFO0 0x00000000 /* FCWM: TFIFO empty
> or RFIFO Full */
> #define SPI_CTL_FIFO1 0x00010000 /* FCWM: TFIFO 75%
> or more empty or RFIFO 75% or more full */
> #define SPI_CTL_FIFO2 0x00020000 /* FCWM: TFIFO 50%
> or more empty or RFIFO 50% or more full */

There ius no need for so much white speace between name and value; and
explanation can be given in a much terse way, or summarized in a
comment preceeding these defines.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There were meetings. There were always meetings. And they were dull,
which is part of the reason they were meetings. Dull likes company.
- Terry Pratchett, _Making_Money_