public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] Tegra: MMC: Add DT support to MMC driver for all T20 boards
Date: Mon, 11 Feb 2013 18:33:52 +0100	[thread overview]
Message-ID: <1360604032.1537.7.camel@tellur> (raw)
In-Reply-To: <1360603051-29478-3-git-send-email-twarren@nvidia.com>

Am Montag, den 11.02.2013, 10:17 -0700 schrieb Tom Warren:
> tegra_mmc_init() now parses the DT info for bus width, WP/CD GPIOs, etc.
> Tested on Seaboard, fully functional.
> 
> Tamonten boards (medcom-wide, plutux, and tec) use a different/new
> dtsi file w/common settings.
> 
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
> v2:
> - all boards now call tegra_mmc_init once, w/no params
> - count MMC controllers, not aliases
> - AD boards (medcom/plutux/tec) use common tegra20-tamonten.dtsi
> 
>  arch/arm/include/asm/arch-tegra/mmc.h             |    2 +-
>  arch/arm/include/asm/arch-tegra/tegra_mmc.h       |   13 +-
>  board/avionic-design/common/tamonten.c            |    4 +-
>  board/compal/paz00/paz00.c                        |   11 +-
>  board/compulab/trimslice/trimslice.c              |    9 +-
>  board/nvidia/harmony/harmony.c                    |   11 +-
>  board/nvidia/seaboard/seaboard.c                  |   11 +-
>  board/nvidia/whistler/whistler.c                  |    7 +-
>  board/toradex/colibri_t20_iris/colibri_t20_iris.c |    2 +-
>  drivers/mmc/tegra_mmc.c                           |  259 +++++++++++++--------
>  include/configs/medcom-wide.h                     |    2 +
>  include/configs/plutux.h                          |    2 +
>  include/configs/tec.h                             |    2 +
>  include/fdtdec.h                                  |    1 +
>  lib/fdtdec.c                                      |    1 +
>  15 files changed, 197 insertions(+), 140 deletions(-)
> 
[...]
> diff --git a/board/nvidia/harmony/harmony.c b/board/nvidia/harmony/harmony.c
> index 93430ed..fba06c2 100644
> --- a/board/nvidia/harmony/harmony.c
> +++ b/board/nvidia/harmony/harmony.c
> @@ -58,18 +58,13 @@ static void pin_mux_mmc(void)
>  /* this is a weak define that we are overriding */
>  int board_mmc_init(bd_t *bd)
>  {
> -	debug("board_mmc_init called\n");
> +	debug("%s called\n", __func__);
>  
>  	/* Enable muxes, etc. for SDMMC controllers */
>  	pin_mux_mmc();
>  
> -	debug("board_mmc_init: init SD slot J26\n");
> -	/* init dev 0, SD slot J26, with 8-bit bus */
> -	tegra_mmc_init(0, 8, GPIO_PI6, GPIO_PH2);
> -
> -	debug("board_mmc_init: init SD slot J5\n");
> -	/* init dev 2, SD slot J5, with 4-bit bus */
> -	tegra_mmc_init(2, 4, GPIO_PT3, GPIO_PI5);
> +	debug("%s: init MMC devs\n", __func__);
> +	tegra_mmc_init();
>  
tegra_mmc_init should not be called from every individual board file,
but from the common nvidia tegra board file. Only the pinmux should stay
in the individual board code, same thing as was done to all the other
functions like NAND and USB.
>  	return 0;
>  }
[...]

Regards,
Lucas

  reply	other threads:[~2013-02-11 17:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 17:17 [U-Boot] [PATCH v2 0/2] Tegra: MMC: Add DT support for MMC to T20 boards Tom Warren
2013-02-11 17:17 ` [U-Boot] [PATCH v2 1/2] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tom Warren
2013-02-11 17:28   ` Lucas Stach
2013-02-11 17:56     ` Tom Warren
2013-02-11 18:55       ` Lucas Stach
2013-02-11 19:11       ` Thierry Reding
2013-02-11 19:21         ` Tom Warren
2013-02-12  6:51           ` Thierry Reding
2013-02-12 10:41             ` Thierry Reding
2013-02-12 10:53               ` Thierry Reding
2013-02-12 17:36                 ` Tom Warren
2013-02-12 20:19               ` Stephen Warren
2013-02-12 20:47                 ` Thierry Reding
2013-02-12 20:17           ` Stephen Warren
2013-02-12 20:29   ` Stephen Warren
2013-02-12 20:52     ` Tom Warren
2013-02-11 17:17 ` [U-Boot] [PATCH v2 2/2] Tegra: MMC: Add DT support to MMC driver for all T20 boards Tom Warren
2013-02-11 17:33   ` Lucas Stach [this message]
2013-02-11 17:59     ` Tom Warren
2013-02-12 19:24       ` Tom Warren
2013-02-12 19:41         ` Lucas Stach
2013-02-12 19:50           ` Tom Warren
2013-02-12 20:38   ` Stephen Warren
2013-02-12 20:57     ` Tom Warren
2013-02-12 21:06       ` Stephen Warren
2013-02-13 19:59         ` Tom Warren
2013-02-13 20:02           ` Stephen Warren
2013-02-13 20:06             ` Tom Warren
2013-02-13 20:09               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360604032.1537.7.camel@tellur \
    --to=dev@lynxeye.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox