* [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
@ 2013-01-16 8:34 Holger Brunck
2013-02-11 3:39 ` Prafulla Wadaskar
0 siblings, 1 reply; 5+ messages in thread
From: Holger Brunck @ 2013-01-16 8:34 UTC (permalink / raw)
To: u-boot
From: Gerlando Falauto <gerlando.falauto@keymile.com>
If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead of
the 1-bit error correction code on the NAND device.
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Valentin Longchamp <valentin.longchamp@keymile.com>
cc: Prafulla Wadaskar <prafulla@marvell.com>
---
drivers/mtd/nand/kirkwood_nand.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/kirkwood_nand.c b/drivers/mtd/nand/kirkwood_nand.c
index bdab5aa..0a99a10 100644
--- a/drivers/mtd/nand/kirkwood_nand.c
+++ b/drivers/mtd/nand/kirkwood_nand.c
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int chip)
int board_nand_init(struct nand_chip *nand)
{
nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+#if defined(CONFIG_NAND_ECC_BCH)
+ nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
nand->ecc.mode = NAND_ECC_SOFT;
+#endif
nand->cmd_ctrl = kw_nand_hwcontrol;
nand->chip_delay = 40;
nand->select_chip = kw_nand_select_chip;
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
2013-01-16 8:34 [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH Holger Brunck
@ 2013-02-11 3:39 ` Prafulla Wadaskar
2013-02-11 19:25 ` Scott Wood
2013-04-08 8:42 ` Gerlando Falauto
0 siblings, 2 replies; 5+ messages in thread
From: Prafulla Wadaskar @ 2013-02-11 3:39 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Holger Brunck [mailto:holger.brunck at keymile.com]
> Sent: 16 January 2013 14:04
> To: u-boot at lists.denx.de
> Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla
> Wadaskar
> Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
>
> From: Gerlando Falauto <gerlando.falauto@keymile.com>
>
> If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead
> of
> the 1-bit error correction code on the NAND device.
>
> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> drivers/mtd/nand/kirkwood_nand.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/kirkwood_nand.c
> b/drivers/mtd/nand/kirkwood_nand.c
> index bdab5aa..0a99a10 100644
> --- a/drivers/mtd/nand/kirkwood_nand.c
> +++ b/drivers/mtd/nand/kirkwood_nand.c
> @@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int
> chip)
> int board_nand_init(struct nand_chip *nand)
> {
> nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
> +#if defined(CONFIG_NAND_ECC_BCH)
> + nand->ecc.mode = NAND_ECC_SOFT_BCH;
> +#else
> nand->ecc.mode = NAND_ECC_SOFT;
> +#endif
> nand->cmd_ctrl = kw_nand_hwcontrol;
> nand->chip_delay = 40;
> nand->select_chip = kw_nand_select_chip;
Acked-by: Prafulla Wadaskar <prafulla@marvell.com>
Will pull this latter.
Regards...
Prafulla . . .
> --
> 1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
2013-02-11 3:39 ` Prafulla Wadaskar
@ 2013-02-11 19:25 ` Scott Wood
2013-04-08 8:42 ` Gerlando Falauto
1 sibling, 0 replies; 5+ messages in thread
From: Scott Wood @ 2013-02-11 19:25 UTC (permalink / raw)
To: u-boot
On 02/10/2013 09:39:08 PM, Prafulla Wadaskar wrote:
>
>
> > -----Original Message-----
> > From: Holger Brunck [mailto:holger.brunck at keymile.com]
> > Sent: 16 January 2013 14:04
> > To: u-boot at lists.denx.de
> > Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla
> > Wadaskar
> > Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
> >
> > From: Gerlando Falauto <gerlando.falauto@keymile.com>
> >
> > If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code
> instead
> > of
> > the 1-bit error correction code on the NAND device.
> >
> > Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
> > Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> > cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> > cc: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> > drivers/mtd/nand/kirkwood_nand.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/kirkwood_nand.c
> > b/drivers/mtd/nand/kirkwood_nand.c
> > index bdab5aa..0a99a10 100644
> > --- a/drivers/mtd/nand/kirkwood_nand.c
> > +++ b/drivers/mtd/nand/kirkwood_nand.c
> > @@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd,
> int
> > chip)
> > int board_nand_init(struct nand_chip *nand)
> > {
> > nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
> > +#if defined(CONFIG_NAND_ECC_BCH)
> > + nand->ecc.mode = NAND_ECC_SOFT_BCH;
> > +#else
> > nand->ecc.mode = NAND_ECC_SOFT;
> > +#endif
> > nand->cmd_ctrl = kw_nand_hwcontrol;
> > nand->chip_delay = 40;
> > nand->select_chip = kw_nand_select_chip;
>
> Acked-by: Prafulla Wadaskar <prafulla@marvell.com>
> Will pull this latter.
Acked-by: Scott Wood <scottwood@freescale.com>
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
2013-02-11 3:39 ` Prafulla Wadaskar
2013-02-11 19:25 ` Scott Wood
@ 2013-04-08 8:42 ` Gerlando Falauto
2013-04-08 8:46 ` Prafulla Wadaskar
1 sibling, 1 reply; 5+ messages in thread
From: Gerlando Falauto @ 2013-04-08 8:42 UTC (permalink / raw)
To: u-boot
Hi Prafulla,
could you please pull these before we hit 2013.04?
Namely:
http://patchwork.ozlabs.org/patch/212438/
http://patchwork.ozlabs.org/patch/212441/
http://patchwork.ozlabs.org/patch/212439/
http://patchwork.ozlabs.org/patch/212440/
Thanks!
Gerlando
On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote:
>
>
>> -----Original Message-----
>> From: Holger Brunck [mailto:holger.brunck at keymile.com]
>> Sent: 16 January 2013 14:04
>> To: u-boot at lists.denx.de
>> Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla
>> Wadaskar
>> Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
>>
>> From: Gerlando Falauto <gerlando.falauto@keymile.com>
>>
>> If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead
>> of
>> the 1-bit error correction code on the NAND device.
>>
>> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
>> cc: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>> drivers/mtd/nand/kirkwood_nand.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/kirkwood_nand.c
>> b/drivers/mtd/nand/kirkwood_nand.c
>> index bdab5aa..0a99a10 100644
>> --- a/drivers/mtd/nand/kirkwood_nand.c
>> +++ b/drivers/mtd/nand/kirkwood_nand.c
>> @@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int
>> chip)
>> int board_nand_init(struct nand_chip *nand)
>> {
>> nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
>> +#if defined(CONFIG_NAND_ECC_BCH)
>> + nand->ecc.mode = NAND_ECC_SOFT_BCH;
>> +#else
>> nand->ecc.mode = NAND_ECC_SOFT;
>> +#endif
>> nand->cmd_ctrl = kw_nand_hwcontrol;
>> nand->chip_delay = 40;
>> nand->select_chip = kw_nand_select_chip;
>
> Acked-by: Prafulla Wadaskar <prafulla@marvell.com>
> Will pull this latter.
>
> Regards...
> Prafulla . . .
>
>> --
>> 1.7.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH
2013-04-08 8:42 ` Gerlando Falauto
@ 2013-04-08 8:46 ` Prafulla Wadaskar
0 siblings, 0 replies; 5+ messages in thread
From: Prafulla Wadaskar @ 2013-04-08 8:46 UTC (permalink / raw)
To: u-boot
Sure, I will check and do the needful, thanks.
Regards...
Prafulla . . .
> -----Original Message-----
> From: Gerlando Falauto
> [mailto:gerlando.falauto at keymile.com]
> Sent: 08 April 2013 14:12
> To: Prafulla Wadaskar
> Cc: Brunck, Holger; u-boot at lists.denx.de; Longchamp,
> Valentin
> Subject: Re: [PATCH] kirkwood_nand: allow usage of
> NAND_ECC_SOFT_BCH
>
> Hi Prafulla,
>
> could you please pull these before we hit 2013.04?
>
> Namely:
> http://patchwork.ozlabs.org/patch/212438/
> http://patchwork.ozlabs.org/patch/212441/
> http://patchwork.ozlabs.org/patch/212439/
> http://patchwork.ozlabs.org/patch/212440/
>
> Thanks!
> Gerlando
>
> On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Holger Brunck
> [mailto:holger.brunck at keymile.com]
> >> Sent: 16 January 2013 14:04
> >> To: u-boot at lists.denx.de
> >> Cc: Gerlando Falauto; Holger Brunck; Valentin
> Longchamp; Prafulla
> >> Wadaskar
> >> Subject: [PATCH] kirkwood_nand: allow usage of
> NAND_ECC_SOFT_BCH
> >>
> >> From: Gerlando Falauto
> <gerlando.falauto@keymile.com>
> >>
> >> If CONFIG_NAND_ECC_BCH is set use 4-bit error
> correction code instead
> >> of
> >> the 1-bit error correction code on the NAND device.
> >>
> >> Signed-off-by: Gerlando Falauto
> <gerlando.falauto@keymile.com>
> >> Signed-off-by: Holger Brunck
> <holger.brunck@keymile.com>
> >> cc: Valentin Longchamp
> <valentin.longchamp@keymile.com>
> >> cc: Prafulla Wadaskar <prafulla@marvell.com>
> >> ---
> >> drivers/mtd/nand/kirkwood_nand.c | 4 ++++
> >> 1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/kirkwood_nand.c
> >> b/drivers/mtd/nand/kirkwood_nand.c
> >> index bdab5aa..0a99a10 100644
> >> --- a/drivers/mtd/nand/kirkwood_nand.c
> >> +++ b/drivers/mtd/nand/kirkwood_nand.c
> >> @@ -74,7 +74,11 @@ void kw_nand_select_chip(struct
> mtd_info *mtd, int
> >> chip)
> >> int board_nand_init(struct nand_chip *nand)
> >> {
> >> nand->options = NAND_COPYBACK | NAND_CACHEPRG |
> NAND_NO_PADDING;
> >> +#if defined(CONFIG_NAND_ECC_BCH)
> >> + nand->ecc.mode = NAND_ECC_SOFT_BCH;
> >> +#else
> >> nand->ecc.mode = NAND_ECC_SOFT;
> >> +#endif
> >> nand->cmd_ctrl = kw_nand_hwcontrol;
> >> nand->chip_delay = 40;
> >> nand->select_chip = kw_nand_select_chip;
> >
> > Acked-by: Prafulla Wadaskar <prafulla@marvell.com>
> > Will pull this latter.
> >
> > Regards...
> > Prafulla . . .
> >
> >> --
> >> 1.7.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-08 8:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 8:34 [U-Boot] [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH Holger Brunck
2013-02-11 3:39 ` Prafulla Wadaskar
2013-02-11 19:25 ` Scott Wood
2013-04-08 8:42 ` Gerlando Falauto
2013-04-08 8:46 ` Prafulla Wadaskar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox