From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 18/23] ppc: Enable generic board support
Date: Tue, 12 Feb 2013 16:40:03 -0600 [thread overview]
Message-ID: <1360708803.24612.14@snotra> (raw)
In-Reply-To: <CAPnjgZ2p82Bbs36HKze9Kv7zBDCFzhj8+VebYuAXm1uv3EEHcw@mail.gmail.com> (from sjg@chromium.org on Tue Feb 12 16:29:56 2013)
On 02/12/2013 04:29:56 PM, Simon Glass wrote:
> Hi Scott,
>
> On Tue, Feb 12, 2013 at 12:38 PM, Scott Wood
> <scottwood@freescale.com> wrote:
> > On 02/08/2013 09:12:14 AM, Simon Glass wrote:
> >>
> >> This enables generic board support so that ppc boards can define
> >> CONFIG_SYS_GENERIC_BOARD.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> ---
> >> Changes in v5: None
> >> Changes in v4: None
> >> Changes in v3: None
> >> Changes in v2: None
> >>
> >> arch/powerpc/config.mk | 3 ---
> >> arch/powerpc/include/asm/u-boot.h | 7 +++++++
> >> arch/powerpc/lib/Makefile | 2 ++
> >> 3 files changed, 9 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
> >> index bf77090..b706281 100644
> >> --- a/arch/powerpc/config.mk
> >> +++ b/arch/powerpc/config.mk
> >> @@ -29,9 +29,6 @@ PLATFORM_RELFLAGS += -fpic -mrelocatable
> >> -ffunction-sections -fdata-sections
> >> PLATFORM_CPPFLAGS += -DCONFIG_PPC -D__powerpc__
> >> PLATFORM_LDFLAGS += -n
> >>
> >> -# Move to unified board system later
> >> -CONFIG_SYS_LEGACY_BOARD := y
> >> -
> >> #
> >> # When cross-compiling on NetBSD, we have to define __PPC__ or
> else we
> >> # will pick up a va_list declaration that is incompatible with the
> >> diff --git a/arch/powerpc/include/asm/u-boot.h
> >> b/arch/powerpc/include/asm/u-boot.h
> >> index 7229a98..951dd6a 100644
> >> --- a/arch/powerpc/include/asm/u-boot.h
> >> +++ b/arch/powerpc/include/asm/u-boot.h
> >> @@ -34,6 +34,11 @@
> >> * include/asm-ppc/u-boot.h
> >> */
> >>
> >> +#ifdef CONFIG_SYS_GENERIC_BOARD
> >> +/* Use the generic board which requires a unified bd_info */
> >> +#include <asm-generic/u-boot.h>
> >> +#else
> >
> >
> > Note that a unified bd_info means you're breaking compatibility
> with old,
> > pre-device-tree kernels (including possibly some non-Linux OSes
> that still
> > don't use the device tree) -- in which case why keep it around at
> all?
>
> It's not intended to break things - are you saying that every arch is
> defined to use a different variant of bd_t in these OSes, or are you
> just referring to PPC?
Any OS that uses bd_info is going to rely on things not changing (other
than additions to the end) from whatever was used for that particular
platform at the time the OS copied the struct definition.
-Scott
next prev parent reply other threads:[~2013-02-12 22:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 15:11 [U-Boot] [PATCH v5 0/23] Create generic board init for ARM, x86, PPC Simon Glass
2013-02-08 15:11 ` [U-Boot] [PATCH v5 01/23] ppc: Add initial memory barrier macros Simon Glass
2013-02-11 19:52 ` Scott Wood
2013-02-12 18:44 ` Simon Glass
2013-02-12 18:50 ` Scott Wood
2013-02-12 18:55 ` Simon Glass
2013-02-12 19:04 ` Scott Wood
2013-02-12 19:06 ` Simon Glass
2013-02-08 15:11 ` [U-Boot] [PATCH v5 02/23] Introduce generic u-boot.h file Simon Glass
2013-02-08 15:11 ` [U-Boot] [PATCH v5 03/23] Replace __bss_end__ with __bss_end Simon Glass
2013-02-18 20:13 ` Tom Rini
2013-02-18 21:40 ` Otavio Salvador
2013-02-19 0:23 ` Simon Glass
2013-02-19 0:30 ` Otavio Salvador
2013-02-19 0:32 ` Simon Glass
2013-02-18 23:20 ` Andy Fleming
2013-02-08 15:12 ` [U-Boot] [PATCH v5 04/23] Introduce generic link section.h symbol files Simon Glass
2013-02-18 20:12 ` Tom Rini
2013-02-08 15:12 ` [U-Boot] [PATCH v5 05/23] arm: Use sections header to obtain link symbols Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 06/23] x86: nds32: Change stub example to use asm-generic/sections.h Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 07/23] Introduce a basic initcall implementation Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 08/23] Define CONFIG_SYS_LEGACY_BOARD everywhere Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 09/23] Declare watchdog functions in watchdog.h Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 10/23] Introduce generic pre-relocation board_f.c Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 11/23] Introduce generic post-relocation board_r.c Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 12/23] Add spl load feature Simon Glass
2013-02-12 20:29 ` Scott Wood
2013-02-12 22:23 ` Simon Glass
2013-02-12 22:34 ` Scott Wood
2013-03-02 23:39 ` Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 13/23] arm: Remove use of board_early_init_r/last_stage_init() Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 14/23] arm: Enable generic board support Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 15/23] Add CONFIG_SYS_SYM_OFFSETS to support offset symbols Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 16/23] Adjust board_f.c for ppc Simon Glass
2013-02-12 22:32 ` Scott Wood
2013-02-12 22:41 ` Simon Glass
2013-02-12 22:48 ` Scott Wood
2013-02-08 15:12 ` [U-Boot] [PATCH v5 17/23] Adjust board_r.c " Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 18/23] ppc: Enable generic board support Simon Glass
2013-02-12 20:38 ` Scott Wood
2013-02-12 22:29 ` Simon Glass
2013-02-12 22:40 ` Scott Wood [this message]
2013-02-08 15:12 ` [U-Boot] [PATCH v5 19/23] x86: Adjust board_f.c for x86 Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 20/23] x86: Adjust board_r.c " Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 21/23] x86: Use sections header to obtain link symbols Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 22/23] x86: Enable generic board support Simon Glass
2013-02-08 15:12 ` [U-Boot] [PATCH v5 23/23] tegra: Enable generic board for Seaboard Simon Glass
2013-02-08 17:23 ` Stephen Warren
2013-02-08 18:10 ` Simon Glass
2013-02-08 19:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360708803.24612.14@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox