From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 06/19] nand: mxc: Use appropriate page number in syndrome functions
Date: Mon, 18 Feb 2013 18:30:23 -0600 [thread overview]
Message-ID: <1361233823.25178.4@snotra> (raw)
In-Reply-To: <1360961665-10693-6-git-send-email-benoit.thebaudeau@advansee.com> (from benoit.thebaudeau@advansee.com on Fri Feb 15 14:54:12 2013)
On 02/15/2013 02:54:12 PM, Beno?t Th?baudeau wrote:
> The syndrome functions should use the page number passed as argument
> instead of
> the page number saved upon NAND_CMD_READ0.
>
> This does not make any difference if the NAND_NO_AUTOINCR option is
> set, but
> otherwise this fixes accesses to the wrong pages.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> ---
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4:
> - New patch.
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/mtd/nand/mxc_nand.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 249328e..001c2c0 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -504,7 +504,7 @@ static int mxc_nand_read_page_raw_syndrome(struct
> mtd_info *mtd,
> int n;
>
> _mxc_nand_enable_hwecc(mtd, 0);
> - chip->cmdfunc(mtd, NAND_CMD_READ0, 0x00, host->page_addr);
> + chip->cmdfunc(mtd, NAND_CMD_READ0, 0x00, page);
>
> for (n = 0, steps = chip->ecc.steps; steps > 0; n++, steps--) {
> host->col_addr = n * eccsize;
> @@ -548,7 +548,7 @@ static int mxc_nand_read_page_syndrome(struct
> mtd_info *mtd,
> uint8_t *oob = chip->oob_poi;
>
> MTDDEBUG(MTD_DEBUG_LEVEL1, "Reading page %u to buf %p oob %p\n",
> - host->page_addr, buf, oob);
> + page, buf, oob);
>
> /* first read the data area and the available portion of OOB */
> for (n = 0; eccsteps; n++, eccsteps--, p += eccsize) {
> @@ -586,7 +586,7 @@ static int mxc_nand_read_page_syndrome(struct
> mtd_info *mtd,
>
> /* Then switch ECC off and read the OOB area to get the ECC
> code */
> _mxc_nand_enable_hwecc(mtd, 0);
> - chip->cmdfunc(mtd, NAND_CMD_READOOB, mtd->writesize,
> host->page_addr);
> + chip->cmdfunc(mtd, NAND_CMD_READOOB, mtd->writesize, page);
> eccsteps = chip->ecc.steps;
> oob = chip->oob_poi + chip->ecc.prepad;
> for (n = 0; eccsteps; n++, eccsteps--, p += eccsize) {
The debug print in mxc_nand_read_oob_syndrome() also needs to be fixed.
-Scott
next prev parent reply other threads:[~2013-02-19 0:30 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 20:54 [U-Boot] [PATCH v7 01/19] nand: mxc: Prepare to add support for i.MX5 Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 02/19] nand: mxc: Add " Benoît Thébaudeau
2013-02-26 15:33 ` Fabio Estevam
2013-02-26 16:08 ` Benoît Thébaudeau
2013-02-26 16:35 ` Fabio Estevam
2013-02-26 16:49 ` Benoît Thébaudeau
2013-02-26 17:03 ` Fabio Estevam
2013-02-26 17:08 ` Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 03/19] imx: mx5: lowlevel_init: Simplify code Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 04/19] imx: mx53ard: Add support for NAND Flash Benoît Thébaudeau
2013-02-26 13:22 ` Fabio Estevam
2013-02-26 13:35 ` Fabio Estevam
2013-02-26 14:21 ` Fabio Estevam
2013-02-26 16:53 ` Benoît Thébaudeau
2013-02-26 17:33 ` Fabio Estevam
2013-02-15 20:54 ` [U-Boot] [PATCH v7 05/19] nand: mxc: Fix debug trace in mxc_nand_read_oob_syndrome() Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 06/19] nand: mxc: Use appropriate page number in syndrome functions Benoît Thébaudeau
2013-02-19 0:30 ` Scott Wood [this message]
2013-02-19 11:31 ` Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 07/19] arm: start.S: Fix _TEXT_BASE for SPL Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 08/19] arm: relocate_code() is no longer noreturn Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 09/19] arm1136: Remove redundant relocate_code() return Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 10/19] arm: relocate_code(): Remove useless relocation offset computation Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 11/19] arm: relocate_code(): Use __image_copy_end for end of relocation Benoît Thébaudeau
2013-02-16 18:47 ` Albert ARIBAUD
2013-02-16 19:54 ` Benoît Thébaudeau
2013-02-17 14:30 ` Albert ARIBAUD
2013-02-15 20:54 ` [U-Boot] [PATCH v7 12/19] arm: crt0.S: Remove bogus .globl Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 13/19] Makefile: u-boot-with-spl.bin: Fix SPL padding Benoît Thébaudeau
2013-02-17 16:16 ` Benoît Thébaudeau
2013-02-18 12:28 ` Benoît Thébaudeau
2013-02-18 17:58 ` Scott Wood
2013-02-18 16:50 ` Tom Rini
2013-02-18 17:26 ` Benoît Thébaudeau
2013-02-18 17:27 ` Tom Rini
2013-02-18 18:00 ` Benoît Thébaudeau
2013-02-18 18:02 ` Scott Wood
2013-02-18 18:22 ` Benoît Thébaudeau
2013-02-18 18:24 ` Scott Wood
2013-02-18 18:52 ` Benoît Thébaudeau
2013-02-18 19:11 ` Scott Wood
2013-02-18 19:30 ` Benoît Thébaudeau
2013-02-22 17:36 ` Fabio Estevam
2013-02-22 18:05 ` Benoît Thébaudeau
2013-02-18 19:37 ` Scott Wood
2013-02-18 19:52 ` Benoît Thébaudeau
2013-02-18 19:47 ` Scott Wood
2013-02-18 20:01 ` Benoît Thébaudeau
2013-02-18 20:06 ` Scott Wood
2013-02-18 20:16 ` Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 14/19] imx: Fix automatic make targets for imx images Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 15/19] nand: mxc: Switch NAND SPL to generic SPL Benoît Thébaudeau
2013-02-22 19:14 ` Fabio Estevam
2013-02-22 19:30 ` Fabio Estevam
2013-02-22 20:09 ` Benoît Thébaudeau
2013-02-22 20:55 ` Troy Kisky
2013-02-22 21:07 ` Fabio Estevam
2013-02-22 23:09 ` Marek Vasut
2013-02-22 21:06 ` Fabio Estevam
2013-02-22 21:13 ` Benoît Thébaudeau
2013-02-22 21:26 ` Fabio Estevam
2013-02-22 21:24 ` Benoît Thébaudeau
2013-02-22 21:30 ` Troy Kisky
2013-02-22 21:27 ` Benoît Thébaudeau
2013-02-22 21:31 ` Benoît Thébaudeau
2013-02-22 21:40 ` Benoît Thébaudeau
2013-02-22 21:53 ` Fabio Estevam
2013-02-22 21:51 ` Fabio Estevam
2013-02-22 22:02 ` Fabio Estevam
2013-02-22 22:03 ` Fabio Estevam
2013-02-22 22:08 ` Fabio Estevam
2013-02-22 22:42 ` Benoît Thébaudeau
2013-02-22 22:56 ` Fabio Estevam
2013-02-22 23:11 ` Marek Vasut
2013-02-22 23:12 ` Benoît Thébaudeau
2013-02-22 23:56 ` Marek Vasut
2013-02-23 0:55 ` Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 16/19] arm926ejs: Remove deprecated and now unused NAND SPL Benoît Thébaudeau
2013-02-17 15:51 ` Benoît Thébaudeau
2013-02-17 16:04 ` Albert ARIBAUD
2013-02-17 16:08 ` Albert ARIBAUD
2013-02-17 16:25 ` Benoît Thébaudeau
2013-02-18 12:24 ` Benoît Thébaudeau
2013-02-18 16:40 ` Tom Rini
2013-02-18 20:39 ` Benoît Thébaudeau
2013-02-18 20:56 ` Tom Rini
2013-02-15 20:54 ` [U-Boot] [PATCH v7 17/19] arm: Remove unused relocate_code() parameters Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 18/19] imx: Add u-boot-with-spl.imx make target Benoît Thébaudeau
2013-02-15 20:54 ` [U-Boot] [PATCH v7 19/19] imx: Add u-boot-with-nand-spl.imx " Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361233823.25178.4@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox