From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/13] mxs: spi: Remove CONFIG_MXS_SPI_DMA_ENABLE
Date: Sat, 23 Feb 2013 13:43:00 +0100 [thread overview]
Message-ID: <1361623389-31095-4-git-send-email-marex@denx.de> (raw)
In-Reply-To: <1361623389-31095-1-git-send-email-marex@denx.de>
The CONFIG_MXS_SPI_DMA_ENABLE is no longer relevant as the SPI DMA
has proven to work correctly. Remove this configuration option.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
---
drivers/spi/mxs_spi.c | 16 ----------------
include/configs/m28evk.h | 1 -
include/configs/mx28evk.h | 1 -
3 files changed, 18 deletions(-)
diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
index b5b32dc..ffa3c1d 100644
--- a/drivers/spi/mxs_spi.c
+++ b/drivers/spi/mxs_spi.c
@@ -40,17 +40,6 @@
#define MXSSSP_SMALL_TRANSFER 512
-/*
- * CONFIG_MXS_SPI_DMA_ENABLE: Experimental mixed PIO/DMA support for MXS SPI
- * host. Use with utmost caution!
- *
- * Enabling this is not yet recommended since this
- * still doesn't support transfers to/from unaligned
- * addresses. Therefore this driver will not work
- * for example with saving environment. This is
- * caused by DMA alignment constraints on MXS.
- */
-
struct mxs_spi_slave {
struct spi_slave slave;
uint32_t max_khz;
@@ -347,12 +336,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
char dummy;
int write = 0;
char *data = NULL;
-
-#ifdef CONFIG_MXS_SPI_DMA_ENABLE
int dma = 1;
-#else
- int dma = 0;
-#endif
if (bitlen == 0) {
if (flags & SPI_XFER_END) {
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 1b51fe2..59a7be9 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -244,7 +244,6 @@
#ifdef CONFIG_CMD_SPI
#define CONFIG_HARD_SPI
#define CONFIG_MXS_SPI
-#define CONFIG_MXS_SPI_DMA_ENABLE
#define CONFIG_SPI_HALF_DUPLEX
#define CONFIG_DEFAULT_SPI_BUS 2
#define CONFIG_DEFAULT_SPI_CS 0
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 71447d9..6a46f3c 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -202,7 +202,6 @@
#ifdef CONFIG_CMD_SPI
#define CONFIG_HARD_SPI
#define CONFIG_MXS_SPI
-#define CONFIG_MXS_SPI_DMA_ENABLE
#define CONFIG_SPI_HALF_DUPLEX
#define CONFIG_DEFAULT_SPI_BUS 2
#define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
--
1.7.10.4
next prev parent reply other threads:[~2013-02-23 12:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 12:42 [U-Boot] [PATCH 01/13] mxs: Reset the EMI block on mx23 Marek Vasut
2013-02-23 12:42 ` [U-Boot] [PATCH 02/13] mxs: mmc: spi: dma: Better wrap the MXS differences Marek Vasut
2013-02-23 12:42 ` [U-Boot] [PATCH 03/13] mxs: spi: Fix the MXS SPI for mx23 Marek Vasut
2013-02-23 15:28 ` Otavio Salvador
2013-02-23 17:41 ` Marek Vasut
2013-02-23 12:43 ` Marek Vasut [this message]
2013-02-23 14:11 ` [U-Boot] [PATCH 04/13] mxs: spi: Remove CONFIG_MXS_SPI_DMA_ENABLE Fabio Estevam
2013-02-23 17:25 ` Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 05/13] mxs: Squash the header file usage in ehci-mxs Marek Vasut
2013-02-23 15:32 ` Otavio Salvador
2013-02-23 12:43 ` [U-Boot] [PATCH 06/13] mxs: Make ehci-mxs multiport capable Marek Vasut
2013-02-23 15:31 ` Otavio Salvador
2013-02-23 12:43 ` [U-Boot] [PATCH 07/13] mxs: m28: Enable power to USB port 0 Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 08/13] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 09/13] mx23: Document the tRAS lockout setting in memory initialization Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 10/13] mx23evk: Adjust DRAM control register to use full 128MB of RAM Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 11/13] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 12/13] mxs: Fix iomux.h to not break build during assembly stage Marek Vasut
2013-02-23 12:43 ` [U-Boot] [PATCH 13/13] mx23_olinuxino: Add support for status LED Marek Vasut
2013-02-23 15:27 ` [U-Boot] [PATCH 01/13] mxs: Reset the EMI block on mx23 Otavio Salvador
2013-02-23 17:41 ` Marek Vasut
2013-02-23 17:54 ` Otavio Salvador
2013-02-23 18:48 ` Marek Vasut
2013-02-23 17:55 ` Marek Vasut
2013-03-07 16:56 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361623389-31095-4-git-send-email-marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox