From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Date: Thu, 28 Feb 2013 15:58:27 +0100 Subject: [U-Boot] [PATCH 2/2] ARM: tegra: make CONFIG_CMD_PART common In-Reply-To: <512E74A9.7070700@wwwdotorg.org> References: <1361919658-3150-1-git-send-email-swarren@wwwdotorg.org> <1361919658-3150-2-git-send-email-swarren@wwwdotorg.org> <512E74A9.7070700@wwwdotorg.org> Message-ID: <1362063507.1907.1.camel@antimon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am Mittwoch, den 27.02.2013, 14:03 -0700 schrieb Stephen Warren: > On 02/26/2013 04:00 PM, Stephen Warren wrote: > > This is useful on all Tegras, so that boot.scr on all devices can use > > the same commands. Hence, move it to tegra-common.h. > > Unfortunately, this breaks Tegra114 builds because no partition types > are enabled, and CONFIG_CMD_PART requires functionality that's only > enabled if some partition types are supported. > > There are two possible solutions: > > 1) Conditionally enable PARTITION_UUIDS and CMD_PART in > tegra-common-post.h only if some partition type is enabled. > > 2) Also enable DOS and EFI partitions in tegra-common.h, along with all > of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards > this won't be any change. For the Colibri T20 and Avionic Design boards, > this ends up enabling a few more options. > > (or perhaps enable all of those in tegra-common-post.h only if support > for any block device is enabled) > > I prefer option (2). Does anyone object? > No objections. There is no real reason to leave out all those options as we are not size limited on the Colibri. Regards, Lucas