From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/5] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS
Date: Mon, 4 Mar 2013 19:35:08 -0600 [thread overview]
Message-ID: <1362447308.16575.12@snotra> (raw)
In-Reply-To: <51354A0C.3040901@ti.com> (from trini@ti.com on Mon Mar 4 19:27:40 2013)
On 03/04/2013 07:27:40 PM, Tom Rini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/04/2013 08:12 PM, Scott Wood wrote:
> > On 03/04/2013 04:17:10 PM, Tom Rini wrote:
> >> The flag changed from WITH_INLINE_OOB to WITH_YAFFS_OOB by
> >> accident in 418396e.
> >>
> >> Signed-off-by: Tom Rini <trini@ti.com> --- Changes in v4: - Add
> >> patch to fix CONFIG_CMD_NAND_YAFFS
> >>
> >> Changes in v3: None Changes in v2: None
> >>
> >> common/cmd_nand.c | 2 +- 1 file changed, 1 insertion(+), 1
> >> deletion(-)
> >>
> >> diff --git a/common/cmd_nand.c b/common/cmd_nand.c index
> >> 76f4d3f..d9010d2 100644 --- a/common/cmd_nand.c +++
> >> b/common/cmd_nand.c @@ -673,7 +673,7 @@ static int
> >> do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const
> >> argv[]) } ret = nand_write_skip_bad(nand, off, &rwsize, NULL,
> >> maxsize, (u_char *)addr, -
> >> WITH_INLINE_OOB); + WITH_YAFFS_OOB);
> >> #endif
> >
> > Oops. Probably a leftover from an attempt to share code between
> > yaffs and raw accesses.
> >
> > BTW, it looks like there is no board that selects
> > CONFIG_CMD_NAND_YAFFS, so it doesn't get compile tested... ...and
> > smdk6400 defines CONFIG_SYS_NAND_YAFFS_WRITE, which nothing ever
> > tests. :-P
>
> Indeed. We lack some real users of YAFFS in U-Boot right now, and I
> don't wish to open a can of worms on why that might be.
I see some other things in nand_write_skip_bad() that look broken for
WITH_YAFFS_OOB (but have been there since before WITH_YAFFS_OOB was
introduced...), in particular check_skip_len() and the call to
nand_write() when need_skip is 0.
Sorry if some worms just popped out. :-)
-Scott
next prev parent reply other threads:[~2013-03-05 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 22:17 [U-Boot] [PATCH v4 0/5] Add NAND support to DFU, enable for am335x_evm Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 1/5] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 2/5] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS Tom Rini
2013-03-05 1:12 ` Scott Wood
2013-03-05 1:27 ` Tom Rini
2013-03-05 1:35 ` Scott Wood [this message]
2013-03-04 22:17 ` [U-Boot] [PATCH v4 3/5] dfu: NAND specific routines for DFU operation Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 4/5] am335x_evm: Add CONFIG_CMD_MTDPARTS and relevant defaults Tom Rini
2013-03-04 22:17 ` [U-Boot] [PATCH v4 5/5] am335x_evm: Enable DFU for NAND and MMC, provide example alt_info for both Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362447308.16575.12@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox