[U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

Tom Rini
2013-03-08T20:27:48Z

On Thu, Dec 20, 2012 at 11:51:05AM -0000, Scott Wood wrote:

> SPL doesn't write to the environment. These list entries prevent the
> functions from being garbage-collected, even though nothing will look at
> the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to
> break due to size limitations and/or unresolved symbols.
>
> A static inline function is used to provide a context in which we
> can consume the callback, and thus avoid unused function warnings.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Acked-by: Joe Hershberger <joe.hershberger@gmail.com>
> Acked-by: Kim Phillips <kim.phillips@freescale.com>

OK, this isn't quite right.
On am335x_evm where SPL does use the "full" version of the environment,
rather than the restricted version that say a3m071 we need these these
callbacks to be generated. We usually build successfully since in these
cases our #include of <u-boot.lst> picks up the one in include that the
main SPL generates. But with enough cores we build SPL before we build
this list for non-SPL, and the build fails. I shall submit a patch
shortly for this.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130308/a6ce8582/attachment.pgp>