From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL
Date: Tue, 12 Mar 2013 12:06:53 -0500 [thread overview]
Message-ID: <1363108013.17135.4@snotra> (raw)
In-Reply-To: <20130312170256.GJ23324@bill-the-cat> (from trini@ti.com on Tue Mar 12 12:02:56 2013)
On 03/12/2013 12:02:56 PM, Tom Rini wrote:
> On Tue, Mar 12, 2013 at 11:55:22AM -0500, Scott Wood wrote:
> > On 03/12/2013 10:30:40 AM, Tom Rini wrote:
> > >On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood wrote:
> > >> Why would eliminating all individual callbacks cause start/end
> to go
> > >> away? If that's the way the list mechanism works, the mechanism
> > >> needs fixing.
> > >
> > >Yes, that's how the mechanism works. Rather than having to
> > >declare that
> > >you expect to have a linker list of name $foo, we dynamically
> > >determine
> > >what linker lists we have and setup the linker section entry.
> >
> > So it would break just as hard if we happened to turn off all of the
> > things that register callbacks.
> >
> > >I'm not sure it's broken exactly, I think maybe we just need to
> > >say no env
> > >callback support in SPL since it's not really user editable.
> >
> > That's fine, but it's still a bad mechanism.
>
> Yes, the mechanism has a breaking condition on trying to reference an
> empty list (which is what SPL ends up with, in this case). Poking
> Albert and Marek in case they have any ideas, but this seems like a
> feature not a bug.
How is it a feature? One of the main benefit of linker lists is for
things to just work when things are configured in/out without needing
ifdefs and such. Why should "everything configured out" be a special
case requiring an ifdef?
If we want to save some code by ifdeffing the listwalking code for SPL,
that's a separate matter.
-Scott
next prev parent reply other threads:[~2013-03-12 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 21:51 [U-Boot] [PATCH v2] env: don't generate callback list entries for SPL Scott Wood
2012-12-20 22:49 ` Kim Phillips
2012-12-22 15:19 ` Tom Rini
2013-03-08 20:27 ` [U-Boot] [U-Boot, " Tom Rini
2013-03-08 20:34 ` Scott Wood
2013-03-08 20:59 ` Tom Rini
2013-03-09 0:35 ` Scott Wood
2013-03-12 15:30 ` Tom Rini
2013-03-12 16:55 ` Scott Wood
2013-03-12 17:02 ` Tom Rini
2013-03-12 17:06 ` Scott Wood [this message]
2013-03-12 17:19 ` Albert ARIBAUD
2013-03-12 17:47 ` Tom Rini
2013-03-12 22:07 ` Albert ARIBAUD
2013-03-13 18:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363108013.17135.4@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox