[U-Boot] [PATCH 01/21] common: Update cmd_bdinfo for PPC

[U-Boot] [PATCH 01/21] common: Update cmd_bdinfo for PPC

[York Sun]

Add board detail function to print more individual board information.

Signed-off-by: York Sun <yorksun@freescale.com>
---
 common/cmd_bdinfo.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index 85279d5..3bf8cf2 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -84,6 +84,12 @@ static void print_mhz(const char *name, unsigned long hz)
 }
 
 #if defined(CONFIG_PPC)
+static void __board_detail(void)
+{
+	/* Please define boot_detail() for your platform */
+}
+
+void board_detail(void) __attribute__((weak, alias("__board_detail")));
 
 int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
@@ -169,6 +175,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	printf("IP addr     = %s\n", getenv("ipaddr"));
 	printf("baudrate    = %6u bps\n", bd->bi_baudrate);
 	print_num("relocaddr", gd->relocaddr);
+	board_detail();
 	return 0;
 }
 
-- 
1.7.9.5

[U-Boot] [PATCH 01/21] common: Update cmd_bdinfo for PPC

[Wolfgang Denk]

Dear York Sun,

In message <1363972995-25836-1-git-send-email-yorksun@freescale.com> you wrote:
> Add board detail function to print more individual board information.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
>  common/cmd_bdinfo.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index 85279d5..3bf8cf2 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -84,6 +84,12 @@ static void print_mhz(const char *name, unsigned long hz)
>  }
>  
>  #if defined(CONFIG_PPC)
> +static void __board_detail(void)
> +{
> +	/* Please define boot_detail() for your platform */
> +}

This comment here is pretty much misleading.  We are not suppoed to
add any coe here, right?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Each team building another component has been using the  most  recent
tested  version  of the integrated system as a test bed for debugging
its piece. Their work will be set back by having that test bed change
under them. Of course it must. But the changes need to be  quantized.
Then  each  user  has periods of productive stability, interrupted by
bursts of test-bed change. This seems to be much less disruptive than
a constant rippling and trembling.
                     - Frederick Brooks Jr., "The Mythical Man Month"